Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old build files #655

Closed
jakirkham opened this issue Dec 9, 2023 · 0 comments · Fixed by #665
Closed

Cleanup old build files #655

jakirkham opened this issue Dec 9, 2023 · 0 comments · Fixed by #665
Milestone

Comments

@jakirkham
Copy link
Member

jakirkham commented Dec 9, 2023

As part of 23.12, we move to the RAPIDS wheel build process ( #619 ). That said, there are still some leftover bit from the old build process. Trying to document things we might consider cleaning up here


CUDA 11.0 & 11.1 Dockerfiles, which haven't seen much attention

FROM dockcross/manylinux2014-x64:20230215-2dd9a1c

FROM dockcross/manylinux2014-x64:20230215-2dd9a1c

Note: Some time ago RAPIDS issued a deprecation notice for CUDA 11.0 and recommended moving to CUDA 11.2. More recently RAPIDS issued a deprecation notice for CUDA 11.2 recommending moving to CUDA 11.8 as a minimum

Given all this, think we should drop these Dockerfiles


.dockerignore file. Unneeded if no Dockerfiles are here

!docker


Old build scripts. Looks like these are part of the old wheel build process

#!/bin/bash

#!/bin/bash

DEFAULT_DOCKCROSS_IMAGE=gigony/manylinux2014-x64:cuda110

auditwheel.elfutils, "elf_is_python_extension", elf_is_python_extension

run_command docker build --runtime nvidia -t cucim-jupyter${gds_postfix} -f ${TOP}/docker/Dockerfile-jupyter${gds_postfix} ${TOP}

# Build libcucim


Also these lines from

cucim/run

Lines 265 to 281 in 87410cd

build_manylinux2014_desc() { echo 'Build manylinux2014 image
Arguments:
$1 - cuda version (e.g., 110, 111)
'
}
build_manylinux2014() {
local cuda_version="${1:-110}"
run_command docker build -f ${TOP}/Dockerfile-cuda${cuda_version} -t gigony/manylinux2014-x64:cuda${cuda_version} ${TOP}
read -n 1 -r -p "$(c_str R "Do you want to update dockcross-manylinux2014-x64 with " G "cuda${cuda_version}" R " (y/n)?")"
echo
if [[ $REPLY =~ ^[Yy]$ ]]; then
sed -i -e "s/manylinux2014-x64:cuda.../manylinux2014-x64:cuda${cuda_version}/g" ${TOP}/dockcross-manylinux2014-x64
c_echo W "Done"
fi
}


And these lines from the license

cucim/LICENSE-3rdparty.md

Lines 290 to 295 in 87410cd

dockcross
- License: MIT License
- https://github.com/dockcross/dockcross/blob/master/LICENSE
- Copyright: Steeve Morin, Rob Burns, Matthew McCormick, Jean-Christophe-Fillion-Robin, Bensuperpc
- Usage: Building Python wheels for Linux


Some requirement files that seem to be used with the aforementioned Docker images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant