Skip to content

Commit

Permalink
Require click as a wheel dependency
Browse files Browse the repository at this point in the history
Trying to `import cucim` results in `import click`, which fails if
`click` is not installed. This was encountered recently by a user that
tested out the cuCIM wheel packages.

The Conda packages already solve this by adding `click` to
`requirements/run`. So this makes an equivalent change to the wheel
packages.

Should fix user install issues.
  • Loading branch information
jakirkham committed Apr 2, 2024
1 parent eee3e4c commit 4bfbb0e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ dependencies:
common:
- output_types: [conda, requirements, pyproject]
packages:
- click
- lazy_loader>=0.1
- numpy>=1.23.4,<2.0a0
- scikit-image>=0.19.0,<0.23.0a0
Expand All @@ -257,7 +258,6 @@ dependencies:
# possible to run `pip install .` from the python/cucim folder
# without having build the C++ library at all. This allows, usage of
# usage of `cucim.skimage` on Windows, for example.
- click
- jbig
- libwebp-base
- xz
Expand Down Expand Up @@ -297,7 +297,6 @@ dependencies:
- openslide-python>=1.3.0; platform_machine=='x86_64'
- matplotlib
- opencv-python-headless>=4.6
- click
- output_types: [pyproject]
packages:
# Already added to requirements via docs. This is for tests.
Expand Down
2 changes: 1 addition & 1 deletion python/cucim/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ authors = [
license = { text = "Apache 2.0" }
requires-python = ">=3.9"
dependencies = [
"click",
"cupy-cuda11x>=12.0.0",
"lazy_loader>=0.1",
"numpy>=1.23.4,<2.0a0",
Expand Down Expand Up @@ -57,7 +58,6 @@ Tracker = "https://github.com/rapidsai/cucim/issues"
[project.optional-dependencies]
test = [
"GPUtil>=1.4.0",
"click",
"imagecodecs>=2021.6.8; platform_machine=='x86_64'",
"matplotlib",
"numpydoc>=1.5",
Expand Down

0 comments on commit 4bfbb0e

Please sign in to comment.