Ensure CommunicationError is raised correctly, not EncryptionError

[cgranleese-r7]

Note

This PR is in conjunction with a PR in Metasploit-Framework . This PR will need to be landed before the framework PR.

This PR is to add a more precise error being raised when a session is dead. Currently in Metasploit-Framework if a session dies we would have had a RubySMB::Error::EncryptionError error being raised which wasn't accurate. This change will now raise an RubySMB::Error::CommunicationError when a session dies, which feels a lot closer in terms of accuracy.

[adfoster-r7]

For the context that you plan to use this in; if the session is killed - will the message be shown to the user as an encryption error?

[cgranleese-r7]

Good point. Should I add logic above this to check if the response is nil and raise a specific message for that scenario, or do you have something in mind?

Suggested change

	raise e, "Communication error with the "\
	raise RubySMB::Error::CommunicationError, "An error occurred reading from the Socket #{e.message}" if raw_response.nil?
	if encrypt
	raise e, "Communication error with the "\

[cgranleese-r7]

Hmm, actually doing my suggestion leave us in almost the same scenario we were for my original implementation. So probably not what we want 🤔

[adfoster-r7]

I think long-term we should probably handle this better, potentially special casing this error if it's got a connection to a windows 8 target

For now, maybe we could just re-word the error message to be less clear-cut that the communication error was caused by encryption issues

      if encrypt
          raise e, "Communication error with the "\
            "remote host: #{e.message}. The server supports encryption and this error may have been caused by encryption issues."

Or maybe we could have special case for the amount of encrypted messages sent already, and if it's more than 1 - we just don't need this message any more