Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileBothDirectoryInformation ShortNameLength definition is wrong #218

Open
gwillcox-r7 opened this issue May 9, 2022 · 0 comments
Open
Labels

Comments

@gwillcox-r7
Copy link
Contributor

The line at https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information/file_both_directory_information.rb#L22 defines ShortNameLength as an unsigned 8 bit integer. According to the definitions at https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/270df317-9ba5-4ccb-ba00-8d22be139bc5, this should actually be a signed 8 bit integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant