Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly dependency updates #16539

Merged
merged 3 commits into from
May 9, 2022
Merged

Weekly dependency updates #16539

merged 3 commits into from
May 9, 2022

Conversation

jmartin-tech
Copy link
Contributor

@jmartin-tech jmartin-tech commented May 5, 2022

This PR should have been auto-generated by actions/github-script. bundle update revealed the following gems have new version to be evaluated for update.

More adjustment to get automation are in progress, for now let us pick this week.

Verification

List the steps needed to make sure this thing works

  • Security review diffs for updated gems

@jmartin-tech jmartin-tech added rn-no-release-notes no release notes automation New APIs and services for automation labels May 5, 2022
@gwillcox-r7 gwillcox-r7 self-assigned this May 9, 2022
Gemfile.lock Show resolved Hide resolved
Gemfile.lock Show resolved Hide resolved
Gemfile.lock Show resolved Hide resolved
Gemfile.lock Show resolved Hide resolved
Gemfile.lock Outdated Show resolved Hide resolved
Gemfile.lock Show resolved Hide resolved
@@ -445,7 +445,7 @@ GEM
ruby-progressbar (1.11.0)
ruby-rc4 (0.1.5)
ruby2_keywords (0.0.5)
ruby_smb (3.1.1)
ruby_smb (3.1.2)
Copy link
Contributor

@gwillcox-r7 gwillcox-r7 May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many changes to list here. Found a bug here as well where ShortNameLength field for FileBothDirectoryInformation is a unsigned number where it should be a signed number and raised it at rapid7/ruby_smb#218. There are also several other changes that likely should be made to the specs for a few areas however still in the process of reviewing the code for this since its a fairly large change.

@gwillcox-r7 gwillcox-r7 merged commit 653e48e into master May 9, 2022
@gwillcox-r7 gwillcox-r7 deleted the weekly-dependency-updates branch May 9, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation New APIs and services for automation rn-no-release-notes no release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants