Changes from code review

rapid7 · Dec 5, 2024 · 1090b3b · 1090b3b
1 parent b8d54d6
commit 1090b3b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/ruby_smb/dcerpc/samr.rb b/lib/ruby_smb/dcerpc/samr.rb
@@ -360,7 +360,7 @@ def self.encrypt_hash(hash:, key:)
             cipher.key = key2
           end
 
-          cipher1.update(block1) + cipher2.update(block2)
+          cipher1.update(block1) + cipher1.final + cipher2.update(block2) + cipher2.final
         end
       end
 
@@ -400,7 +400,7 @@ def self.encrypt_password(password, old_password_nt)
             cipher.encrypt
             cipher.key = old_password_nt
           end
-          cipher.update(buffer)
+          cipher.update(buffer) + cipher.final
         end
       end
 

diff --git a/lib/ruby_smb/dcerpc/samr/samr_get_members_in_group_response.rb b/lib/ruby_smb/dcerpc/samr/samr_get_members_in_group_response.rb
@@ -14,7 +14,7 @@ class PsamprGetMembersBuffer < SamprGetMembersBuffer
         extend Ndr::PointerClassPlugin
       end
 
-      # [3.1.5.8.3 SamrGetMembersInGroup (Opnum 25)](https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-samr/a4adbf20-040f-4416-a960-e5b7917fdae7)
+      # [3.1.5.8.3 SamrGetMembersInGroup (Opnum 25)](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-samr/3ed5030d-88a3-42ca-a6e0-8c12aa2fdfbd)
       class SamrGetMembersInGroupResponse < BinData::Record
         attr_reader :opnum