Add sip-banner record for Telepresence with higher certainty #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <example os.version="X8.2.1" hw.product="TANDBERG/4130" tandberg.model="4130">TANDBERG/4130 (X8.2.1)</example> | ||
| <example os.version="XC2.2.1-b2bua-1.0" hw.product="TANDBERG/4353" tandberg.model="4353">TANDBERG/4353 (XC2.2.1-b2bua-1.0)</example> | ||
| <example os.version="TC5.1.4.295090" hw.product="TANDBERG/516" tandberg.model="516">TANDBERG/516 (TC5.1.4.295090)</example> | ||
| <example os.version="TCNC5.1.4.295090" hw.product="TANDBERG/517" tandberg.model="517">TANDBERG/517 (TCNC5.1.4.295090)</example> |
There was a problem hiding this comment.
I'm wondering if it wouldn't make sense to keep the old examples as well? Looks like they have somewhat different format. This way we would be sure we are backward compatible version-wise. 🤔 Wdyt?
There was a problem hiding this comment.
I agree, we should probably keep the existing examples, unless we identify they were not correct.
mlaskowski-r7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A detailed description of your changes.
Updated sip-banner record for Cisco Telepresence to reflect the current product naming, vendor, family. Make regex more strict to match only versions starting with X and TC.
SIP protocol example:
SIP/2.0 403 Forbidden
Via: SIP/2.0/UDP nm;branch=foo;received=224.85.86.107;rport=26810;ingress-zone=DefaultZone
Call-ID: 50000
CSeq: 42 OPTIONS
From: sip:nm@nm;tag=root
To: sip:nm2@nm2;tag=dba04991a2a1090f
Server: TANDBERG/4145 (X15.0.3)
Motivation and Context
How Has This Been Tested?
Tested with bin/recog_verify
Types of changes
Checklist: