Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fingerprints for Cisco IOS XE and Cisco IOS XR #618

Merged

Conversation

mlaskowski-r7
Copy link
Contributor

@mlaskowski-r7 mlaskowski-r7 commented Jun 17, 2024

Description

Added fingerprints for Cisco IOS XE and Cisco IOS XR

Cisco IOS XE:
https://regex101.com/r/X4lCnP/1

Cisco IOS XR:
https://regex101.com/r/ffX7YN/1

Motivation and Context

SNMP fingerprints for Cisco IOS XE and Cisco IOS XR are missing.

How Has This Been Tested?

Added tests covering the changes.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mlaskowski-r7 mlaskowski-r7 self-assigned this Jun 17, 2024
Matched regex #121 ((?-mix:^Cisco (?:Internetwork Operating System|IOS) Software,? (?:\r|\n|.)+Version\s+([^,]+),)) rather than #133 ((?-mix:^Cisco IOS Software.*(?:Virtual XE|IOS-XE) Software.*Version ([\w.()]*)))
@mlaskowski-r7 mlaskowski-r7 marked this pull request as ready for review June 17, 2024 12:06
<param pos="0" name="os.device" value="Router"/>
<param pos="1" name="os.version"/>
</fingerprint>

Copy link
Contributor Author

@mlaskowski-r7 mlaskowski-r7 Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.product, os.family and os.device for both are based on the respective Assessment Framework fingerprinters.

Copy link
Contributor

@martinvotruba-r7 martinvotruba-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adfoster-r7 adfoster-r7 merged commit 4df64d3 into main Jun 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants