Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ffi gem version in Gemfile #615

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

adfoster-r7
Copy link
Contributor

@adfoster-r7 adfoster-r7 commented Jun 12, 2024

Description

Fix CI build failure when running in Ruby 2.7.5 docker environment:

docker run -it -w $(pwd) -v $(pwd):$(pwd) --rm ruby:2.7.5 /bin/sh

Before:

# bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
ffi-1.17.0-x86_64-linux-musl requires rubygems version >= 3.3.22, which is incompatible with the current version, 3.1.6

After:

# bundle
...
Bundle complete! 12 Gemfile dependencies, 49 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
# 

Motivation and Context

Fix CI failing on ffi dependency issues

How Has This Been Tested?

CI passes

Types of changes

  • Bug fix

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@adfoster-r7 adfoster-r7 force-pushed the pin-ffi-version-in-gemfile branch 2 times, most recently from 7aa0a22 to 34f54dd Compare June 12, 2024 15:17
@dwelch-r7 dwelch-r7 merged commit 2779367 into rapid7:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants