Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fingerprints for Cisco Meraki Mx Ms and Mr #611

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Added fingerprints for Cisco Meraki Mx Ms and Mr #611

merged 4 commits into from
Apr 9, 2024

Conversation

mlaskowski-r7
Copy link
Contributor

@mlaskowski-r7 mlaskowski-r7 commented Mar 27, 2024 •
edited
Loading

Description

Added fingerprints for:

  • Meraki MX Cloud-Managed Security and SD-WAN
  • Meraki MR Cloud-Managed Wi-Fi Access Points
  • Meraki MS Cloud-Managed Network Switches

Motivation and Context

Coverage for Cisco Meraki devices is needed.

How Has This Been Tested?

Tested locally if Meraki devices are detected during the Asset Scan.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed. (bin/recog_verify xml/snmp_sysdescr.xml)

@mlaskowski-r7 mlaskowski-r7 self-assigned this Mar 27, 2024
@mlaskowski-r7 mlaskowski-r7 marked this pull request as ready for review March 28, 2024 09:42
martinvotruba-r7
martinvotruba-r7 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@martinvotruba-r7 martinvotruba-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaskowski-r7 mlaskowski-r7 removed the request for review from kburns-r7 April 2, 2024 14:16
@mlaskowski-r7 mlaskowski-r7 merged commit 06ca9e9 into main Apr 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adfoster-r7 adfoster-r7 adfoster-r7 left review comments

@martinvotruba-r7 martinvotruba-r7 martinvotruba-r7 approved these changes

@kmccabe-r7 kmccabe-r7 kmccabe-r7 approved these changes

@sdynes-r7 sdynes-r7 Awaiting requested review from sdynes-r7

Assignees

@mlaskowski-r7 mlaskowski-r7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlaskowski-r7 @adfoster-r7 @kmccabe-r7 @martinvotruba-r7 @sdynes-r7