Merge pull request #625 from rapid7/Fix-device-name-for-cisco-telepre…

…sence Update sip_banners record for Cisco Telepresence
rapid7 · Sep 3, 2024 · 061a67e · 061a67e
2 parents c759276 + aa54ae3
commit 061a67e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/identifiers/os_family.txt b/identifiers/os_family.txt
@@ -189,6 +189,7 @@ System Storage
 T3 Termination
 TASKalfa
 TDS750 Series
+TelePresence
 Teradici
 Time Capsule
 TippingPoint

diff --git a/identifiers/os_product.txt b/identifiers/os_product.txt
@@ -69,15 +69,16 @@ Document Centre
 Dynix
 EDR G902 Firmware
 EDR-G903 Firmware
+EOS
 EdgeBlaster
 EdgeOS
 Email Appliance
 Enterprise AP
 Enterprise Linux
 Enterprise WAP
-EOS
 EqualLogic
 Excella
+Expressway
 FRITZ!OS
 Fabric OS
 Fastmark M5

diff --git a/xml/sip_banners.xml b/xml/sip_banners.xml
@@ -163,13 +163,12 @@
     <param pos="2" name="hw.version"/>
   </fingerprint>
 
-  <fingerprint pattern="^TANDBERG/(\d+) \((.*)\) Cisco-(\S+)$">
+  <fingerprint pattern="^TANDBERG\/(\d+) \((X\d+\S*|XC\d+\S*|TC\d+\S*|TCNC\d+\S*).*\) Cisco-(\S+)$">
     <description>Cisco/Tandberg TelePresence w/Cisco Model Name</description>
     <example os.version="TC7.3.7.01c84fd" tandberg.model="528" hw.product="EX60">TANDBERG/528 (TC7.3.7.01c84fd) Cisco-EX60</example>
-    <example os.version="ce9.6.0.76c1685b70e" tandberg.model="529" hw.product="RoomKitMini">TANDBERG/529 (ce9.6.0.76c1685b70e) Cisco-RoomKitMini</example>
-    <param pos="0" name="os.vendor" value="Tandberg"/>
-    <param pos="0" name="os.family" value="Linux"/>
-    <param pos="0" name="os.product" value="Linux"/>
+    <param pos="0" name="os.vendor" value="Cisco"/>
+    <param pos="0" name="os.family" value="TelePresence"/>
+    <param pos="0" name="os.product" value="Expressway"/>
     <param pos="1" name="tandberg.model"/>
     <param pos="2" name="os.version"/>
     <param pos="0" name="hw.vendor" value="Cisco"/>
@@ -178,25 +177,25 @@
     <param pos="3" name="hw.product"/>
   </fingerprint>
 
-  <fingerprint pattern="^(TANDBERG/(\d+)) \((\S+).*\)$">
+  <fingerprint pattern="^(TANDBERG\/(\d+)) \((X\d+\S*|XC\d+\S*|TC\d+\S*|TCNC\d+\S*).*\)$">
     <description>Cisco/Tandberg TelePresence</description>
     <example os.version="TC7.0.2.aecf2d9" tandberg.model="519" hw.product="TANDBERG/519">TANDBERG/519 (TC7.0.2.aecf2d9)</example>
     <example os.version="X12.5.2" tandberg.model="4137" hw.product="TANDBERG/4137">TANDBERG/4137 (X12.5.2 (TEST SW))</example>
     <example os.version="X8.2.1" hw.product="TANDBERG/4130" tandberg.model="4130">TANDBERG/4130 (X8.2.1)</example>
     <example os.version="XC2.2.1-b2bua-1.0" hw.product="TANDBERG/4353" tandberg.model="4353">TANDBERG/4353 (XC2.2.1-b2bua-1.0)</example>
     <example os.version="TC5.1.4.295090" hw.product="TANDBERG/516" tandberg.model="516">TANDBERG/516 (TC5.1.4.295090)</example>
     <example os.version="TCNC5.1.4.295090" hw.product="TANDBERG/517" tandberg.model="517">TANDBERG/517 (TCNC5.1.4.295090)</example>
-    <param pos="0" name="os.vendor" value="Tandberg"/>
-    <param pos="0" name="os.family" value="Linux"/>
-    <param pos="0" name="os.product" value="Linux"/>
+    <param pos="0" name="os.vendor" value="Cisco"/>
+    <param pos="0" name="os.family" value="TelePresence"/>
+    <param pos="0" name="os.product" value="Expressway"/>
+    <param pos="0" name="os.device" value="Video Conferencing"/>
     <param pos="2" name="tandberg.model"/>
     <param pos="3" name="os.version"/>
     <param pos="0" name="hw.vendor" value="Cisco"/>
     <param pos="0" name="hw.family" value="TelePresence"/>
     <param pos="0" name="hw.device" value="Video Conferencing"/>
     <param pos="1" name="hw.product"/>
   </fingerprint>
-
   <!-- NEC -->
 
   <fingerprint pattern="^NEC SL2100/([\d.]+)$">