-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version detection for newer Windows #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add version detection by checking the build number for Server 2019, Server 2022 and Windows 11.
Merged
5 tasks
Old:
New:
|
Release NotesThis PR adds the ability to give the pretty OS name based on the build version since Microsoft has changed the historic behavior by retaining the major build version as 10 through all Windows 10 and 11 releases, and all Windows server versions from 2016 up to 2022. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version detection by checking the build number for Server 2019, Server 2022 and Windows 11. Server versions also now have the word "Server" in their OS string which more closely resembles the string shown in "System Information" app. The OS Name is typically "Microsoft Windows (?p) (Server)? \d+ (?p)" if written as a regex.
The exception is Windows .NET Server instead of Windows Server 2003 which I've never understood but remains the same.Build numbers were taken from Metasploit to ensure consistency.Testing:
sysinfo
instead of "Windows 10" (in place of Windows 11) or "Windows 2016+" (in place of Windows Server 2019 or Windows Server 2022)