Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Land #19731, new feature for recognizing broken SMB session a… #19761

Closed
wants to merge 1 commit into from
Closed

Revert "Land #19731, new feature for recognizing broken SMB session a… #19761

wants to merge 1 commit into from

Conversation

msutovsky-r7
Copy link
Contributor

Reverting as new commit causes tests to fail:

Randomized with seed 41512
2024-12-23 11:42:56 +0000 Thin web server (v1.8.2 codename Ruby Razor)
2024-12-23 11:42:56 +0000 Maximum connections set to 1024
2024-12-23 11:42:56 +0000 Listening on 0.0.0.0:8080, CTRL+C to stop
[2024-12-23 11:47:54 +0000] Failed, 1 failure
/opt/hostedtoolcache/Ruby/3.1.6/x64/bin/ruby -I/home/runner/work/metasploit-framework/metasploit-framework/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib:/home/runner/work/metasploit-framework/metasploit-framework/vendor/bundle/ruby/3.1.0/gems/rspec-support-3.13.1/lib /home/runner/work/metasploit-framework/metasploit-framework/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/exe/rspec --pattern deliberately-left-blank ./spec/lib/msf/core/windows_version_spec.rb:44 --require rspec-rerun/formatter --format RSpec::Rerun::Formatter --color --format Fivemat --require spec_helper
Overriding user environment variable 'OPENSSL_CONF' to enable legacy functions.
Overriding user environment variable 'OPENSSL_CONF' to enable legacy functions.
Run options:
  include {:locations=>{"./spec/lib/msf/core/windows_version_spec.rb"=>[44]}}
  exclude {:acceptance=>true, :content=>true}

Randomized with seed 40561
Overriding user environment variable 'OPENSSL_CONF' to enable legacy functions.
[!] SSL Disabled
Started process with pid 5540
Msf::WindowsVersion F

  1) Msf::WindowsVersion Reports correct SMB version for single match
     Failure/Error: expect(version_string).to eq('Windows XP')

       expected: #<Encoding:UTF-8> "Windows XP"
            got: #<Encoding:ASCII-8BIT> "Windows XP Service Pack 3"

       (compared using ==)
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-support-3.13.1/lib/rspec/support.rb:110:in `block in <module:Support>'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-support-3.13.1/lib/rspec/support.rb:119:in `notify_failure'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/fail_with.rb:35:in `fail_with'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/handler.rb:37:in `handle_failure'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/handler.rb:55:in `block in handle_matcher'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/handler.rb:26:in `with_matcher'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/handler.rb:47:in `handle_matcher'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/expectation_target.rb:65:in `to'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-expectations-3.13.3/lib/rspec/expectations/expectation_target.rb:101:in `to'
     # ./spec/lib/msf/core/windows_version_spec.rb:49:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:263:in `instance_exec'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:263:in `block in run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:511:in `block in with_around_and_singleton_context_hooks'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:468:in `block in with_around_example_hooks'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/hooks.rb:486:in `block in run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/hooks.rb:626:in `block in run_around_example_hooks_for'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:352:in `call'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-rails-7.0.1/lib/rspec/rails/adapters.rb:75:in `block (2 levels) in <module:MinitestLifecycleAdapter>'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:457:in `instance_exec'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:457:in `instance_exec'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/hooks.rb:390:in `execute_with'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/hooks.rb:628:in `block (2 levels) in run_around_example_hooks_for'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:352:in `call'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/hooks.rb:629:in `run_around_example_hooks_for'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/hooks.rb:486:in `run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:468:in `with_around_example_hooks'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:511:in `with_around_and_singleton_context_hooks'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example.rb:259:in `run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example_group.rb:646:in `block in run_examples'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example_group.rb:642:in `map'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example_group.rb:642:in `run_examples'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/example_group.rb:607:in `run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:121:in `block (3 levels) in run_specs'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:121:in `map'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:121:in `block (2 levels) in run_specs'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/configuration.rb:2097:in `with_suite_hooks'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:116:in `block in run_specs'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/reporter.rb:74:in `report'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:115:in `run_specs'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:89:in `run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:71:in `run'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/lib/rspec/core/runner.rb:45:in `invoke'
     # ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.13.2/exe/rspec:4:in `<main>'

Top 1 slowest examples (0.01183 seconds, 0.4% of total time):
  Msf::WindowsVersion Reports correct SMB version for single match
    0.01183 seconds ./spec/lib/msf/core/windows_version_spec.rb:44

Finished in 3.06 seconds (files took 4.12 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/lib/msf/core/windows_version_spec.rb:44 # Msf::WindowsVersion Reports correct SMB version for single match

@msutovsky-r7
Revert "Land rapid7#19731, new feature for recognizing broken SMB ses…
fd6757e 
…sion and managing them"

This reverts commit 789f7cf, reversing
changes made to 6eb2f61.
@adfoster-r7 adfoster-r7 mentioned this pull request Dec 23, 2024
Merged
@msutovsky-r7 msutovsky-r7 deleted the smb_broken_session_revert branch January 6, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msutovsky-r7