Update User Agent strings for October 2024 #19540
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,56 @@ | ||||||||||||||
| #!/usr/bin/python3 | ||||||||||||||
| import requests | ||||||||||||||
| import re | ||||||||||||||
|
|
||||||||||||||
| def replace_agent_string(lines, replace_marker, url, regex): | ||||||||||||||
| VALID_CHARS = 'a-zA-Z0-9\\(\\);:\\.,/_ ' | ||||||||||||||
| regex = regex.replace('{VALID_CHARS}', VALID_CHARS) | ||||||||||||||
| print(f'Updating {replace_marker}') | ||||||||||||||
| for x in range(0, len(lines)): | ||||||||||||||
| if replace_marker in lines[x]: | ||||||||||||||
| break | ||||||||||||||
|
Comment on lines
+9
to
+11
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. I think this will break the subsequent code when we re-insert it back into the list. We need the index reference to do in-place replacement (unless we also change it to rebuild the list from scratch too). |
||||||||||||||
| else: | ||||||||||||||
| raise RuntimeError(f"Couldn't find marker {replace_marker}") | ||||||||||||||
|
|
||||||||||||||
| response = requests.get(url) | ||||||||||||||
| if response.status_code != 200: | ||||||||||||||
| raise RuntimeError(f"Can't retrieve {url}") | ||||||||||||||
|
|
||||||||||||||
| match = re.search(regex, response.text) | ||||||||||||||
| if match is None: | ||||||||||||||
| raise RuntimeError(f"Couldn't match regex {regex}") | ||||||||||||||
|
|
||||||||||||||
| new_string = match.groups()[0] | ||||||||||||||
| print(f'New value is: {new_string}') | ||||||||||||||
| old_line = lines[x] | ||||||||||||||
| if f"'{new_string}'" in old_line: | ||||||||||||||
| print('(This is unchanged from the previous value)') | ||||||||||||||
| else: | ||||||||||||||
| new_line = re.sub("'(.*)'", f"'{new_string}'", old_line) | ||||||||||||||
| if old_line == new_line: | ||||||||||||||
| raise RuntimeError(f"Line didn't change: {old_line}") | ||||||||||||||
|
|
||||||||||||||
| lines[x] = new_line | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| chrome_url = "https://www.whatismybrowser.com/guides/the-latest-user-agent/chrome" | ||||||||||||||
| edge_url = "https://www.whatismybrowser.com/guides/the-latest-user-agent/edge" | ||||||||||||||
| safari_url = "https://www.whatismybrowser.com/guides/the-latest-user-agent/safari" | ||||||||||||||
| firefox_url = "https://www.whatismybrowser.com/guides/the-latest-user-agent/firefox" | ||||||||||||||
|
|
||||||||||||||
| user_agent_filename = 'lib/rex/user_agent.rb' | ||||||||||||||
| with open(user_agent_filename,'r') as f: | ||||||||||||||
| lines = f.read().splitlines() | ||||||||||||||
|
|
||||||||||||||
| replace_agent_string(lines, 'Chrome Windows', chrome_url, '<td>Chrome \\(Standard\\)</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*Windows NT[{VALID_CHARS}]*)</span>') | ||||||||||||||
| replace_agent_string(lines, 'Chrome MacOS', chrome_url, '<td>Chrome \\(Standard\\)</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*Macintosh[{VALID_CHARS}]*)</span>') | ||||||||||||||
| replace_agent_string(lines, 'Edge Windows', edge_url, '<td>Edge \\(Standard\\)</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*Windows NT[{VALID_CHARS}]*)</span>') | ||||||||||||||
| replace_agent_string(lines, 'Safari iPad', safari_url, '<td>\s*Safari on <b>Ipad</b>\s*</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*iPad[{VALID_CHARS}]*)</span>') | ||||||||||||||
| replace_agent_string(lines, 'Safari MacOS', safari_url, '<td>Safari \\(Standard\\)</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*Macintosh[{VALID_CHARS}]*)</span>') | ||||||||||||||
| replace_agent_string(lines, 'Firefox Windows', firefox_url, '<td>\s*Firefox on <b>Windows</b>\s*</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*Windows NT[{VALID_CHARS}]*)</span>') | ||||||||||||||
| replace_agent_string(lines, 'Firefox MacOS', firefox_url, '<td>\s*Firefox on <b>Macos</b>\s*</td>\s*<td>\s*<ul>\s*<li><span class="code">([{VALID_CHARS}]*Macintosh[{VALID_CHARS}]*)</span>') | ||||||||||||||
|
|
||||||||||||||
| with open(user_agent_filename, 'w') as f: | ||||||||||||||
| f.write('\n'.join(lines) + '\n') | ||||||||||||||
|
|
||||||||||||||
| print('Done') | ||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the script; cross-referencing with: #18120