Fixes a nil error if login is successful with ldap_login module

[cgranleese-r7]

This PR fixes an issue when create_credential_and_login in lib/metasploit/framework/data_service/proxy/credential_data_proxy.rb is called, which doesn't call of to create_credential_login at any point to initialize @report[rhost]. This was causing the nil error as the ldap_login module made use of the Msf::Auxiliary::ReportSummary mixin but never called create_credential_login which is the method the mixin had original overridden. This also wasn't been caught on the CI LDAP acceptance testing as the ldap_session_type feature is set to false by default currently.

Before

[+] 127.0.0.1:389 - Success: 'DEV-AD\Administrator:admin123!'
[*] LDAP session 2 opened (127.0.0.1:54963 -> 127.0.0.1:389) at 2024-09-03 12:16:10 +0100
[-] 127.0.0.1:389 - Failed to setup the session - NoMethodError undefined method `merge!' for nil:NilClass
[*] Scanned 1 of 1 hosts (100% complete)
[*] Scan completed, 0 credentials were successful.
[*] 0 sessions were opened successfully.
[*] Bruteforce completed, 1 credential was successful.
[*] 1 LDAP session was opened successfully.
[*] Auxiliary module execution completed

After

msf6 auxiliary(scanner/ldap/ldap_login) > run

[+] 127.0.0.1:389 - Success: 'DEV-AD\Administrator:admin123!'
[*] LDAP session 4 opened (127.0.0.1:55067 -> 127.0.0.1:389) at 2024-09-03 12:27:32 +0100
[*] Scanned 1 of 1 hosts (100% complete)
[*] Scan completed, 1 credential was successful.

Successful logins
=================

    Host       Public                Private
    ----       ------                -------
    127.0.0.1  DEV-AD\Administrator  admin123!


[*] 1 session was opened successfully.
[*] Bruteforce completed, 1 credential was successful.
[*] 1 LDAP session was opened successfully.
[*] Auxiliary module execution completed

Verification

• Enable the new LDAP session feature features set ldap_session_type true
• Run auxiliary/scanner/ldap/ldap_login against an ldap server to get a session (an example of running an ldap container can be found in the ldap acceptance tests here

  metasploit-framework/.github/workflows/ldap_acceptance.yml

  Lines 67 to 71 in 33ffc14

  	- name: Run samba/ldap docker container
  	working-directory: 'test/ldap'
  	run: |
  	docker compose build
  	docker compose up --wait -d

• Run SPEC_OPTS='--tag acceptance' SPEC_HELPER_LOAD_METASPLOIT=false bundle exec rspec ./spec/acceptance/ldap_spec.rb and ensure those pass locally.

[dwelch-r7]

Release Notes

Fixes a nil error if login is successful with ldap_login module