Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SPIP Modules for Windows Compatibility and Incorporating SPIP Mixin #19406

Closed
wants to merge 134 commits into from

Conversation

Chocapikk
Copy link
Contributor

@Chocapikk Chocapikk commented Aug 22, 2024

Hello Metasploit Team,

I am currently working on refactoring the SPIP modules to ensure they are compatible with Windows and also adapting them to the new module syntax. The goal is to enhance integration and improve cross-platform compatibility.

Modules:

  • exploit/multi/http/spip_rce_form (Moved from exploit/unix/webapp)
  • exploit/unix/webapp/spip_connect_exec (Moved from exploit/unix/webapp)
  • exploit/multi/http/spip_porte_plume_previsu_rce (Missing the mixin only)

Additionally, I would greatly appreciate it if @jvoisin's pull request regarding the SPIP mixin could be merged, as it would allow us to refactor all SPIP modules to use the mixin consistently.

For now, I'm marking this PR as a draft because I'm still actively working on these changes.

@Chocapikk Chocapikk marked this pull request as ready for review August 24, 2024 15:36
@dwelch-r7 dwelch-r7 self-assigned this Aug 27, 2024
@dwelch-r7
Copy link
Contributor

I've landed #19401 if you'd like to rebase this PR

@Chocapikk
Copy link
Contributor Author

Hi everyone,

I've run into some issues with the commit history in this PR, and I'm not sure how to resolve it cleanly. To avoid any confusion and to ensure the changes are properly submitted, I'm going to close this PR and open a new one with a clean history.

Thanks for your understanding, and sorry for the inconvenience!

Chocapikk and others added 30 commits August 30, 2024 19:53
…-5932

- Completely overhauled the method for exploiting the GiveWP plugin by removing dependency on the REST API, which may require authentication.
- Instead, we now use the admin-ajax.php endpoint for retrieving form lists and nonce values, ensuring compatibility even when REST API authentication is required.
- The exploit now works with all form types; however, the give_price_id and give_amount must be set to '0' and '0.00', respectively, as attempts to randomize these values caused the exploit to fail.
Based on some old notes that I never bothered to upstream into metasploit.
1. Add a couple of missing architectures
2. Use `read_file` instead of `cmd_exec + cat`
2. Use File.… instead of `cmd_exec` and `test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.