Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert
unf_ext
for now, which fails to compile on centos6:Caused by:
https://github.com/knu/ruby-unf_ext/blame/c72a36d0a5ea9fe3950611b0f289fc68a2595fcf/ext/unf_ext/unf.cc#L33-L43
I've just raised an issue with the gem - knu/ruby-unf_ext#80 - it might be a small fix that we could contribute, but just wanted to get a sanity check from the maintainers first ✅
Verification