Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note when SMBv1 is supported to the user #19131

Closed
wants to merge 2 commits into from
Closed

Note when SMBv1 is supported to the user #19131

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb94c7f
Note when SMBv1 is supported to the user
nrathaus Apr 24, 2024
a16b4e3
Remove redundant information
nrathaus Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/auxiliary/scanner/smb/smb_version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ def run_host(ip)

info = smb_proto_info
desc = "SMB Detected (versions:#{info[:versions].join(', ')}) (preferred dialect:#{info[:preferred_dialect]})"
if info[:versions].include?(1)
desc << ' (SMBv1: true)'
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be covered on the previous line where (version: includes 1? This seems redundant. I would expect a server that supports SMBv1 to show (versions:1) or (versions:1,2), etc.

info[:capabilities].each do |name, values|
desc << " (#{name} capabilities:#{values.join(', ')})"
end
Expand Down