Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SessionExpirationTimeout is its not at its default value #19119

Closed

Conversation

nrathaus
Copy link
Contributor

@nrathaus nrathaus commented Apr 21, 2024

Resolves #19023

@adfoster-r7
Copy link
Contributor

If I remember correctly, each payload can be configured with its own session expiration baked into the payload itself. I think you can also configure each payload to have a new session expiration set at runtime: https://docs.metasploit.com/docs/using-metasploit/advanced/meterpreter/meterpreter-timeout-control.html#changing-timeouts

Therefore I don't think this PR's approach will work by itself without additional changes; We were thinking it'd probably need to be tracked as part of the sysinfo retrieval when Meterpreter is connecting back - and then potentially additionally updated when the user updates the value via the console in some way. For instance - I don't think we'd want to make fresh RPC calls to Meterpreter for each sessions -v / session -x call

@smcintyre-r7 smcintyre-r7 added the attic Older submissions that we still want to work on again label Oct 25, 2024
Copy link

Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it attic and closed it for now.

What does this generally mean? It could be one or more of several things:

  • It doesn't look like there has been any activity on this pull request in a while
  • We may not have the proper access or equipment to test this pull request, or the contributor doesn't have time to work on it right now.
  • Sometimes the implementation isn't quite right and a different approach is necessary.

We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this!

@github-actions github-actions bot closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attic Older submissions that we still want to work on again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose session expiration timeout
3 participants