Improve how we fingerprint Gitlab versions #18723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally out of scope; it'd be cool to have a auxiliary gitlab version module maybe? 🤔 |
|
So a self-contained module like |
|
Would certainly make testing easier as well |
|
I added a |
|
Awesome 👍 I'll just cross-reference #18120 here too |
| # | ||
| # @return [String,nil] Gitlab version if found, nil otherwise | ||
| def gitlab_version | ||
| version = gitlab_version_css(normalize_uri(target_uri.path)) |
There was a problem hiding this comment.
Are these methods for grabbing the version be reordered to have the most detailed response at the top.
There was a problem hiding this comment.
I ordered them from the least invasive to the most invasive, but I'm open to suggestions wrt. what we want to prioritize.
adfoster-r7
reviewed
Jan 25, 2024
7 tasks
jheysel-r7
reviewed
Feb 21, 2024
|
It seems that msf6 auxiliary(scanner/http/gitlab_version) > set RHOSTS gitlab.torproject.org
RHOSTS => gitlab.torproject.org
msf6 auxiliary(scanner/http/gitlab_version) > run
[*] Error: 2a01:4f8:fff0:4f:266:37ff:feb8:3489: Msf::Exploit::Remote::HTTP::Gitlab::Error::VersionError Unable to determine Gitlab version
[*] Scanned 1 of 2 hosts (50% complete)
[*] Error: 116.202.120.180: Msf::Exploit::Remote::HTTP::Gitlab::Error::VersionError Unable to determine Gitlab version
[*] Scanned 2 of 2 hosts (100% complete)
[*] Auxiliary module execution completed
msf6 auxiliary(scanner/http/gitlab_version) > set RHOSTS https://gitlab.torproject.org/tpo/team
RHOSTS => https://gitlab.torproject.org/tpo/team
msf6 auxiliary(scanner/http/gitlab_version) > run
[+] Gitlab version for 2a01:4f8:fff0:4f:266:37ff:feb8:3489: 16.9.1
[*] Scanned 1 of 2 hosts (50% complete)
[+] Gitlab version for 116.202.120.180: 16.9.1
[*] Scanned 2 of 2 hosts (100% complete)
[*] Auxiliary module execution completed
msf6 auxiliary(scanner/http/gitlab_version) > |
|
Hey @jvoisin, I ran this slightly edited script multiple times while incrementing the page id to collect enterprise versions. Here's the data it collected. If you wouldn't mind sorting the ranges like you did with the community versions and pushing the additions to this PR that would be much appreciated! Thank you!! Gitlab Enterprise Edition Version Hashes
|
Since I was the one suggesting it in #18716, I kinda volunteered to implement it. This improvement is based on [Censys's blogpost](https://censys.com/cve-2021-22205-it-was-a-gitlab-smash/) on the topic, making use of the `/assets/application-….css` files that have a unique name per gitlab versions. The fingerprints were acquired with this bash script: ```bash assetdir="/opt/gitlab/embedded/service/gitlab-rails/public/assets" tags=$(curl "https://hub.docker.com/v2/repositories/gitlab/gitlab-ce/tags?page_size=100" | jq -r '.results[].name') for tag in $tags; do filename=$(docker run --quiet --rm -it --entrypoint "" gitlab/gitlab-ce:$tag ls $assetdir|egrep '^application-.*\.css' | grep -v \.gz | cut -d' ' -f1) echo $tag,$filename done ``` Co-authored-by: cgranleese-r7 <[email protected]>
Co-authored-by: jheysel-r7 <[email protected]>
|
Testing the most recent changes: Range where low and high versions are the sameRange where low and high versions are different |
jheysel-r7
closed this pull request by merging all changes
into
rapid7:master
in
aea95c0
Release NotesA webpage exists that can be reached without authentication that contains a hash that can be used to determine the approximate version of gitlab running on the endpoint. This PR enhances our current GitLab fingerprinting capabilities to include the aforementioned technique. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I was the one suggesting it in #18716, I kinda volunteered to implement it. This improvement is based on Censys's blogpost on the topic, making use of the
/assets/application-….cssfiles that have a unique name per gitlab versions. This behaviour is known to gitlab.The fingerprints were acquired with this bash script:
Moreover, gitlab is leaking its commit hash in a javascript variable, so we can use this as well, as a last resort, since it's less convenient for the users.