Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jtr formats #162

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adfoster-r7
Copy link
Contributor

Updating the JTR formats with john --list=formats and a quick split/sort/print with ruby STDIN.split(", ").map(&:downcase).map(&:strip).sort.join("\n")

nt2
o10glogon
o3logon
o5logon
odf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some of the opencl entries have been removed from this list. Checking framework it looks like that would only impact this line:

rapid7/metasploit-framework@6d2b7e0

But that jtr_format never existed here 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is really only used for search terms from what I can tell, since the value is rare I can see omitting it.

krb5asrep
krb5pa-md5
krb5pa-sha1
krb5tgs
Copy link
Contributor Author

@adfoster-r7 adfoster-r7 Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what the intended semantics of 'non replayable' is when storing these types of creds; But for visibility the Kerberos tickets that are used to generate these hashes are not replayable, whilst the tickets themselves generally last for a day or so - unless they're golden tickets. i.e. hash generated from the original kerberos ticket isn't detailed enough generate the ticket again, or negotiate with Kerberos anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe 'non replayable' refers to if the hash would be usable to create a new authenticated session with the original auth provider, in the case of kerberos tickets I think the ticket itself may be 'non replayable' as it cannot be used to negotiate a new session after it expires, even if it is usable until the expiration with services that will validate it against the original provider.

Copy link
Contributor

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern here is, removal of values a user may already have in the database would make then no longer filterable in the search function based on how this list is utilized in the command parsing.

This may be a moot point as common use case is short lived database content, but worth the mention.

@adfoster-r7
Copy link
Contributor Author

I think this PR is still useful; but I'll put this back into draft until we've decided how we want to use the database to store kerberos tickets moving forwards 👍

@adfoster-r7 adfoster-r7 marked this pull request as draft June 15, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants