-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Palo Alto Cortex XDR | Get Incidents
trigger patch
#2906
Open
cmcnally-r7
wants to merge
41
commits into
develop
Choose a base branch
from
palo_alto_possible_trigger_fix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,006
−8,475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <[email protected]> Co-authored-by: Rajat Upadhyaya <[email protected]>
* SOAR-17026-Bumping requirements of requests * SOAR-17026-Bumping requirements cryptography and idna
* SOAR-17409-Adding fedramp ready flag to plugin * SOAR-17409-Adding timeouts to the requests * SOAR-17409-Addnf deafult to endpoint
…ated SDK to the latest version (#2839)
* Possible solution to caseId * changes * Fixing get_case_details action. SDK Bump and Plugin refresh * Keeping conor happy * changing references in help.md
* Updated SDK to the latest version * Adjusting unit test imports * Fixing Docker Issue. Changed Plugin Spec and altered bin file * Adding new line at the end of the file * Removing unnecessary package from requirements * Additional dependencies after refreshing the plugin * Reverting the defaults and aligning with the examples * Missing default in the plugin's spec * Removing the defaults apart of the Enum type of the fields * Adjusting the defaults for the timeout fields --------- Co-authored-by: rjmurray <[email protected]>
…DK to the latest version (#2840)
…to the latest version (#2848)
… to the latest version (#2849)
…o the latest version (#2837)
…SDK to the latest version (#2846)
… to the latest version (#2847)
…o the latest version (#2853)
…lity named get resource id (#2854)
…r | Updated SDK to the latest version (#2863)
* Addressing snyk vulns. SDK Bump * Cleaning up help.md / plugin.spec * Fixing validator
* Unit tests added * Change data values in samples * Refactor intial run unit test * Add more for intial success unit test * Working on test 2&3 * One test for now * Full test for successful run and pagination * Refactor pagination test, add task Util * Some basic error tests * More errors added, todo list added * Add dedupe test and fix response to return null on the no results found response * Tidy dedupe test * Update version and changelog * Delete more excess response files * Restore original util and update checksum * New line in response files, test for custom_config * All failure tests passing * All failure tests passing * 100% coverage * Remove redundant line in taskutil * Update SDK * Update changelog and pretty print response files
…2878) * Add specific 500 return code for 'retry your request' error * Update version to 2.1.11 & bump sdk to 6.1.4 * Fix SCA * .. And fix checksum * Unit tests added * Add newline at end of response file * Add extra error logging on 2 failed retry attempts * Remove logger in get error, log full decoded response
* Restrain observability Window * feedback
…ia logical operator | Updated action to return more than 500 results (#2885)
* Snyk and SDK Bump * space
* Snyk and SDK * help.md * Updating search help.md * Fix help.md
* snyk and SDK bump * set up help.md
* Add custom config exceptions and update unit tests for errors * Fix bug in get incidents trigger, update version * Update checksum for task schema * Util update, no unit tests for testing * Broken unit test fix 2 * Fix unit tests
…igger (#2903) * Undo change to list split for get incidents trigger * Black formatting * Remove self.maxdiff in unit test * Update spec file
* snyk and sdk - hybrid_analysis * Fixing unit tests * possible path fix? * help.md and space in requirements.txt * json format
* snyk and sdk * deleting integration unit tests
cmcnally-r7
force-pushed
the
palo_alto_possible_trigger_fix
branch
from
October 28, 2024 14:15
98ab88b
to
4a3f263
Compare
rmurray-r7
force-pushed
the
develop
branch
6 times, most recently
from
November 5, 2024 09:13
e7f10ec
to
2e967fc
Compare
joneill-r7
force-pushed
the
develop
branch
3 times, most recently
from
November 14, 2024 17:00
ba715f2
to
9f862b4
Compare
dlaverty-r7
force-pushed
the
develop
branch
2 times, most recently
from
November 20, 2024 12:01
c2f4dd7
to
6629741
Compare
rmurray-r7
force-pushed
the
develop
branch
2 times, most recently
from
December 18, 2024 15:19
1be0264
to
1b1b456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
host
output and put into an object with keyhostname
. If two values found after: split
then make first valuehostname
, and the second valueendpoint_id
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR