#2 Support for Custom Ranges #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
raphoester
requested changes
Sep 5, 2024
…InRange func names
…fyCustomRangesForIntFloatDuration
raphoester
force-pushed
the
specifyCustomRangesForIntFloatDuration
branch
from
9fc5419 to
0ba821a
Compare
|
what do you think @IvanGael ? I adapted your ideas to the new package organization (with methods instead of plain functions) |
|
Maybe add some tests before merging ? |
|
It seems you change a little bit the implementation. The functions Int, MustIntInRange, Bool, Duration, MustDurationInRange, Time, Float, MustFloatInRange, ..Etc have been removed in chaos.go Should I pull the latest changes from the main branch before adding some tests? |
|
Yea, Also the behavior has been adapted to avoid unnecessary redundancy : Range functions become Between |
…fyCustomRangesForIntFloatDuration
…ub.com/IvanGael/chaos into specifyCustomRangesForIntFloatDuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify custom ranges for the Int, Float, and Duration functions instead of always starting at 0.