Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max width for md editor tooltip, Add untitled key, Add logo alt text to metadata #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Dec 6, 2024

Related Item(s)

#452
#443
#438

Changes

  • Set a max width of 90px for tooltips within the v-md-editor component, so that a horizontal scrollbar doesn't appear when the tooltip exits the screen
  • Add the chapters.untitled key into lang.csv, so that the appropriate text appears in the ToC for slides without a title
  • Include the logo alt text within the metadata upon creating a new object

Testing

Steps (#452):

  1. Open a text panel
  2. Decrease the screen width
  3. Hover over the buttons on the right side of the editor
  4. Observe that the horizontal bar doesn't appear

Steps (#443):

  1. Remove the titles from one/more slide
  2. Switch the ToC to horizontal
  3. Open the preview
  4. Observe that the title of each slide without a title (within the ToC) is 'Untitled Slide'
  5. Switch to French and observe the corresponding French text in the ToC

Steps (#438):

  1. Create a new product
  2. Upload a logo and set the alt text
  3. Click Next to proceed to the main editor page
  4. Click Edit Product Metadata
  5. The alt text should be visible

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-452

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @IshavSohal)


src/components/text-editor.vue line 179 at r1 (raw file):

}
:deep(.v-md-editor__tooltip) {
    max-width: 90px;

This one still seems to be happening for me after the changes:
scrollbartext.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants