Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various metadata editor issues #484

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

gordlin
Copy link
Member

@gordlin gordlin commented Dec 4, 2024

Related Item(s)

Issues:
#444
#449

Changes

Testing

Steps:
#444:

  1. Go to the Create new product screen, and scroll down to the metadata details form.
  2. See that all headings are now in sentence case.

#449:

  1. Open any product, and navigate through to the editor.
  2. Click the Edit Metadata button in the sidebar.
  3. You should see a View English/French Config button, allowing you to swap to the metadata for the other language.

Other:

  1. Back on the Load Existing Storylines Product page, ensure the UUID is blank and press "Load". You should only get ONE toast, telling you to enter a UUID first (before, you'd get multiple, with some saying that UUID "" doesn't exist).
  2. Enter a non-existant UUID. You should get ONE toast notifying you the UUID doesn't exist.
  3. Enter a UUID that exists. The form should pop up as expected.

This change is Reviewable

@gordlin gordlin added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/metadata-editor-issues

@gordlin gordlin force-pushed the metadata-editor-issues branch from 02cc385 to 6a01513 Compare December 9, 2024 22:21
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

@yileifeng yileifeng merged commit bc2f3c0 into ramp4-pcar4:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants