Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modified property to video panel schema #483

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add modified property to video panel schema #483

merged 1 commit into from
Dec 13, 2024

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Dec 4, 2024 •
edited by yileifeng
Loading

Related Item(s)

#480

Changes

  • Added modified property to video panel schema in order to avoid a schema error

Notes

The modified property is being added to video panels due to this line

Testing

Steps:

  1. Open a video panel
  2. Upload a video
  3. Go to the advanced editor
  4. There should be no schema errors

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-480

yileifeng
yileifeng approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

RyanCoulsonCA
RyanCoulsonCA approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

gordlin
gordlin approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

szczz
szczz approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@yileifeng yileifeng merged commit aaef709 into ramp4-pcar4:main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordlin gordlin gordlin approved these changes

@yileifeng yileifeng yileifeng approved these changes

@szczz szczz szczz approved these changes

@RyanCoulsonCA RyanCoulsonCA RyanCoulsonCA approved these changes

Assignees
No one assigned
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IshavSohal @RyanCoulsonCA @szczz @yileifeng @gordlin