Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modified property to dynamic panel schema, Fix SVG rendering #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Dec 4, 2024

Related Item(s)

#456
#436

Changes

  • Add modified property to the dynamic panel schema
  • Convert svgs to text rather than blob, so that they are correctly rendered in the editor and preview

Testing

Steps (#436):

  1. Edit an existing product and change the logo to an svg (can use
    git-bash)
  2. Load the product into editor-main
  3. Click the Edit Project Metadata button, and observe that the svg logo is correctly displayed
  4. Upload the svg to an image panel, switch to a different slide and switch back to the image panel
  5. Observe that the svg is correctly displayed
  6. Open the preview
  7. Observe that the svg logo and the svg in the image panel are correctly displayed,

Steps (#456)

  1. Make a new slide with a dynamic panel
  2. Create an image panel and upload an image
  3. Go to advanced editor and there should be no schema error

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-456

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I agree with the index.js changes but should they be part of this PR?

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing that if you paste a link to an external SVG (the git-bash one you linked, for example) and then proceed to the main editor, nothing will load and you'll notice a CORS error in the console. This doesn't need to be fixed in this PR, but we should open a new issue to investigate this.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ If fix not complicated would be great to include in this PR, if takes too long new issue is good

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants