-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle shortened YT URLs, indicate URL support #477
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/video-urls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure where the modified
boolean property that gets added to the video panel config comes from once we upload a URL link, but this breaks the schema
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gordlin)
src/components/video-editor.vue
line 56 at r1 (raw file):
v-tippy="{ placement: 'top', hideOnClick: false, animateFill: true }" > <svg
Can we use an info icon here? From RAMP editor:
Also this should be keyboard accessible - some options include turning into a button and apply inline styling or add some focus tricks with tabindex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either. We should probably open a new issue about this, as (unless I'm wrong) it doesn't seem the changes in this PR are causing the property to appear.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @yileifeng)
src/components/video-editor.vue
line 56 at r1 (raw file):
Previously, yileifeng (Yi Lei Feng) wrote…
Can we use an info icon here? From RAMP editor:
Also this should be keyboard accessible - some options include turning into a button and apply inline styling or add some focus tricks with
tabindex
Donethanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
Related Item(s)
Issue #458
Changes
youtu.be
links.Notes
Tooltip:
Testing
Steps:
?
icon to see a tooltip indicating the types of URLs supported.https://youtu.be/nIFOG9CMr_E?si=4vztPeKp_3-KzPqq
) and click Upload. The URL should be correctly changed to an embed one, and the video preview should properly show the video.This change is