Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shortened YT URLs, indicate URL support #477

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

gordlin
Copy link
Member

@gordlin gordlin commented Nov 29, 2024

Related Item(s)

Issue #458

Changes

  • [FEATURE] Add support for shortened youtu.be links.
  • [FEATURE] Add a tooltip indicating the supported URL formats.
    • From what I can tell, we support youtube links and direct mp4 links. Let me know if there are more.

Notes

Tooltip:
image

Testing

Steps:

  1. Go to any product.
  2. Go to any video panel.
  3. Near the URL input bar, hover over the ? icon to see a tooltip indicating the types of URLs supported.
  4. Input a shortened YouTube URL (e.g. https://youtu.be/nIFOG9CMr_E?si=4vztPeKp_3-KzPqq) and click Upload. The URL should be correctly changed to an embed one, and the video preview should properly show the video.

This change is Reviewable

@gordlin gordlin added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Nov 29, 2024
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/video-urls

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure where the modified boolean property that gets added to the video panel config comes from once we upload a URL link, but this breaks the schema

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gordlin)


src/components/video-editor.vue line 56 at r1 (raw file):

                v-tippy="{ placement: 'top', hideOnClick: false, animateFill: true }"
            >
                <svg

Can we use an info icon here? From RAMP editor:
image.png

Also this should be keyboard accessible - some options include turning into a button and apply inline styling or add some focus tricks with tabindex

Copy link
Member Author

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either. We should probably open a new issue about this, as (unless I'm wrong) it doesn't seem the changes in this PR are causing the property to appear.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @yileifeng)


src/components/video-editor.vue line 56 at r1 (raw file):

Previously, yileifeng (Yi Lei Feng) wrote…

Can we use an info icon here? From RAMP editor:
image.png

Also this should be keyboard accessible - some options include turning into a button and apply inline styling or add some focus tricks with tabindex

Donethanks!

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yileifeng)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

@yileifeng yileifeng merged commit b404587 into ramp4-pcar4:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants