Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable right only toggle for dynamic slide, Remove uuid spellcheck #474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Nov 29, 2024

Related Item(s)

#441
#433

Changes

  • Disable the Make the right panel the full slide toggle for dynamic slides (i.e. for slides with only one panel)
  • Disable spellcheck for the uuid entry field

Testing

Steps:
#433

  1. From the dashboard click Load Existing Storylines Product
  2. Enter random text into the uuid field
  3. Notice there is no red underline
  4. Load an existing product
  5. Click the change uuid link
  6. Enter random text into the uuid field
  7. Notice there is no red underline

#441

  1. Load a product into editor-main
  2. Create a new slide
  3. Create a dynamic panel within this slide
  4. Observe that the Make the right panel the full slide toggle is disabled
  5. Change the panel type, and observe that the toggle is still disabled (since the slide only contains 1 panel)

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-441

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @IshavSohal)


src/components/slide-editor.vue line 41 at r1 (raw file):

                            class="editor-input rounded-none cursor-pointer w-4 h-4"
                            v-model="rightOnly"
                            :disabled="rightOnly || currentSlide.panel.length === 1"

While this does work to disable the button for dynamic panels, it's also disabling the button for any non-dynamic panel that is already full width:

fulldisabled.gif

Copy link
Member Author

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)


src/components/slide-editor.vue line 41 at r1 (raw file):

Previously, RyanCoulsonCA (Ryan Coulson) wrote…

While this does work to disable the button for dynamic panels, it's also disabling the button for any non-dynamic panel that is already full width:

fulldisabled.gif

Donethanks. Now the checkbox should be disabled when it is unchecked and the slide is already full screen, as well as when it is checked and the full screen panel is dynamic

@szczz szczz requested a review from RyanCoulsonCA December 4, 2024 19:46
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you switch the slide to a dynamic slide and then change it to any other slide type, its forced to be a fullscreen panel and you can't change it unless you recreate the slide.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)

@IshavSohal
Copy link
Member Author

This only seems to happen if the 'make right only' checkbox was unchecked when the slide was switched to dynamic. Since the slide is a full screen slide, trying to check the 'make right only' checkbox will result in an error, regardless of the panel type.

Would it be a good idea to check the 'make right only' checkbox upon switching a slide to dynamic?

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think thats slightly confusing, as a user might think they can uncheck that box. We should be dynamically rendering these boxes based on the slide type.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants