-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable right only toggle for dynamic slide, Remove uuid spellcheck #474
base: main
Are you sure you want to change the base?
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-441 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @IshavSohal)
src/components/slide-editor.vue
line 41 at r1 (raw file):
class="editor-input rounded-none cursor-pointer w-4 h-4" v-model="rightOnly" :disabled="rightOnly || currentSlide.panel.length === 1"
While this does work to disable the button for dynamic panels, it's also disabling the button for any non-dynamic panel that is already full width:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
src/components/slide-editor.vue
line 41 at r1 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
While this does work to disable the button for dynamic panels, it's also disabling the button for any non-dynamic panel that is already full width:
Donethanks. Now the checkbox should be disabled when it is unchecked and the slide is already full screen, as well as when it is checked and the full screen panel is dynamic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you switch the slide to a dynamic slide and then change it to any other slide type, its forced to be a fullscreen panel and you can't change it unless you recreate the slide.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
This only seems to happen if the 'make right only' checkbox was unchecked when the slide was switched to dynamic. Since the slide is a full screen slide, trying to check the 'make right only' checkbox will result in an error, regardless of the panel type. Would it be a good idea to check the 'make right only' checkbox upon switching a slide to dynamic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think thats slightly confusing, as a user might think they can uncheck that box. We should be dynamically rendering these boxes based on the slide type.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
Related Item(s)
#441
#433
Changes
Make the right panel the full slide
toggle for dynamic slides (i.e. for slides with only one panel)Testing
Steps:
#433
Load Existing Storylines Product
#441
Make the right panel the full slide
toggle is disabledThis change is