-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit video upload size #430
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/real-video-size-limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @gordlin)
src/components/video-editor.vue
line 204 at r1 (raw file):
// Block files which are too big if (file.size > this.fileSizeLimit * 1000000) {
This is nitpicky, but I believe this should be 1024 * 1024
instead of 1000000
, otherwise we'll be capping it out at slightly less than 75MB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @gordlin and @RyanCoulsonCA)
src/components/video-editor.vue
line 34 at r1 (raw file):
<span class="align-middle inline-block"> <span> <div>{{ $t('editor.video.label.drag') }}</div>
Center this first line by adding a text-align: center
f17fffc
to
8602485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @RyanCoulsonCA and @yileifeng)
src/components/video-editor.vue
line 34 at r1 (raw file):
Donethanks!
src/components/video-editor.vue
line 204 at r1 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
This is nitpicky, but I believe this should be
1024 * 1024
instead of1000000
, otherwise we'll be capping it out at slightly less than 75MB.
Donethanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a temporary blocker as there are merge conflicts in lang.csv
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
8602485
to
1e27582
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Donethanks!
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @RyanCoulsonCA, @szczz, and @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gordlin)
Related Item(s)
Issue #417
Changes
Testing
Steps:
00000000-0000-0000-0000-000000000000
).This change is