-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create caption input for maps and charts #428
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-393 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @IshavSohal)
src/components/helpers/chart-preview.vue
line 67 at r1 (raw file):
</div> <div class="flex mt-4"> <label :for="'chartPreviewCaption' + index" class="font-bold"
There seems to be an alignment issue with the label and the input box. We should center align the text with the input for consistency.
a0aed09
to
4132b98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
src/components/helpers/chart-preview.vue
line 67 at r1 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
There seems to be an alignment issue with the label and the input box. We should center align the text with the input for consistency.
Donethanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 8 files at r1, 1 of 5 files at r2, all commit messages.
Reviewable status: 4 of 8 files reviewed, 3 unresolved discussions (waiting on @IshavSohal)
src/components/map-editor.vue
line 36 at r2 (raw file):
type="text" v-model="panel.caption" placeholder="Add a caption"
This will need a translation!
src/components/helpers/chart-preview.vue
line 75 at r2 (raw file):
type="text" v-model="chart.caption" placeholder="Add a caption"
Same here, needs translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vertically aligning the caption input with the text of the chart name would look nicer for the UI
Reviewed 3 of 8 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @IshavSohal and @RyanCoulsonCA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 8 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @IshavSohal and @RyanCoulsonCA)
adfcdf1
to
19f234e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get this working, but things get a little crowded for smaller screen widths. Let me know if you prefer the way it used to look, or if you have any suggestions.
Reviewable status: 5 of 8 files reviewed, 3 unresolved discussions (waiting on @RyanCoulsonCA, @spencerwahl, and @yileifeng)
src/components/map-editor.vue
line 36 at r2 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
This will need a translation!
Donethanks
src/components/helpers/chart-preview.vue
line 75 at r2 (raw file):
Previously, RyanCoulsonCA (Ryan Coulson) wrote…
Same here, needs translation
Donethanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new look, but looks like the styling for chart caption input was lost in the latest changes?
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially reduced the text input's height to keep it in line with the 'caption:', but it should be good with the original height now
Reviewable status: 7 of 8 files reviewed, 3 unresolved discussions (waiting on @RyanCoulsonCA and @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r2, 2 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IshavSohal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 8 files at r1, 2 of 5 files at r2, 2 of 3 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)
Related Item(s)
#393
Changes
Notes
ramp4-pcar4/story-ramp#505 handles the map caption in the StoryRAMP repo. ramp4-pcar4/story-ramp#507 handles the chart caption.
Testing
Steps:
caption
field with the caption you providedcaption
field with the caption you providedThis change is