Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore respect to the reset button #387

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

szczz
Copy link
Member

@szczz szczz commented Sep 5, 2024

Related Item(s)

#386

Changes

  • Fixes an issue where resetting changes would cause a save action to occur

Testing

Steps:

  1. Make some changes
  2. Reset those changes
  3. Ensure nothing breaks

Not sure why generateConfig was being called here, but there might have been a good reason. We should thoroughly test this to verify that it has no unintended consequences.


This change is Reviewable

Copy link

github-actions bot commented Sep 5, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/RestoreResetRespect

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the button works the first time, but if you make another change and press it again, the table of contents goes blank:
resetchanges.gif

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@szczz szczz force-pushed the RestoreResetRespect branch from 550c443 to 2c2c227 Compare September 5, 2024 19:13
Copy link
Member Author

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops good catch. Should be donethanksed? Don't think loadExisting needs to be set to false if we're editing an existing product to begin with. Behaviour with a new storylines remains unchanged, although the reset changes button still remains active after resetting. Not sure if thats intentional for new products.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work now! It looks like the reset button hangs around for new Storylines on the main branch too, so if that's a problem we can create a new issue for it.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

Copy link
Member

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczz)

@yileifeng yileifeng merged commit 1eb601f into ramp4-pcar4:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants