Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basemap logos #378

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix basemap logos #378

merged 1 commit into from
Aug 26, 2024

Conversation

mohsin-r
Copy link
Member

@mohsin-r mohsin-r commented Aug 20, 2024 •
edited by yileifeng
Loading

Related Item(s)

story-ramp#434

Changes

  • [FIX] Basemap logos will now be displayed appropriately by default.

Testing

Steps:

  1. Create a new map config and ensure that the basemap logos are displayed by default.

This change is Reviewable

@github-actions GitHub Actions
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/basemap-logos

yileifeng
yileifeng approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

james-rae
james-rae approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@james-rae james-rae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

dnlnashed
dnlnashed approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

IshavSohal
IshavSohal approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

szczz
szczz approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mohsin-r)

@yileifeng yileifeng merged commit 4ae4c85 into ramp4-pcar4:main Aug 26, 2024
3 checks passed
@szczz szczz mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlnashed dnlnashed dnlnashed approved these changes

@IshavSohal IshavSohal IshavSohal approved these changes

@yileifeng yileifeng yileifeng approved these changes

@szczz szczz szczz approved these changes

@james-rae james-rae james-rae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mohsin-r @james-rae @szczz @yileifeng @IshavSohal @dnlnashed