Modify routes and add option to change config lang in preview mode #368
Conversation
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/preview-lang-route |
yileifeng
force-pushed
the
preview-lang-route
branch
from
318d580 to
8aa5f1f
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Noticed that when switching between the languages in preview mode multiple times the local server ends up crashing. Not sure how much of an issue this will be in prod.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
yileifeng
force-pushed
the
preview-lang-route
branch
from
8aa5f1f to
a5ed861
Compare
There was a problem hiding this comment.
Did a rework for the preview component to save both lang configs and only trigger a refresh of the Vue component upon language toggle rather than relying on a server fetch. This should solve the issue as the server will not get overloaded. Should be a much faster loadup time as well when switching languages.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @dnlnashed and @RyanCoulsonCA)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Related Item(s)
Closes #311
Changes
Testing
Steps:
Change languages in preview mode by loading the preview route directly through URL as well as loading the preview route through the editor.
This change is