Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various UI issues #298

Merged
merged 1 commit into from
May 14, 2024
Merged

fix various UI issues #298

merged 1 commit into from
May 14, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented May 13, 2024

Related Item(s)

#292, #294

Changes

Testing

Steps:

  1. Open the demo link.
  2. Navigate to the slideshow editor and to the video editor and ensure the buttons are displaying correctly.
  3. Navigate to the map editor and click the preview button. Ensure that the UI buttons are aligned correctly.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-292/#/en/editor

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

Some styling was lost for advanced editor tab in slide with fullscreen panel.

Another minor UI suggestion is to remove the border on metadata page for loading previous products?
image copy 1.png

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member Author

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the advanced editor tab and I've removed the border around the Load Previous button.

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit bf8eacf into ramp4-pcar4:main May 14, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants