Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feedback button in footer #297

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented May 9, 2024

Related Item(s)

#293

Changes

  • Adds a link to the bottom of the editor to provide feedback through email.

Testing

Steps:

  1. Open the demo page.
  2. Ensure the "Send us feedback" button is displaying and working properly.

This change is Reviewable

Copy link

github-actions bot commented May 9, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-293/#/en/editor

Copy link
Member

@james-rae james-rae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @RyanCoulsonCA)


src/components/editor/editor.vue line 133 at r1 (raw file):

        <div class="footer text-right pr-5 editor-button">
            <a
                href="mailto:[email protected]?subject=Storylines Editor Feedback"

You might need to have the subject= content also run through the translation module


src/lang/lang.csv line 24 at r1 (raw file):

fullscreen.activate,Enter Fullscreen,1,Afficher le mode plein écran,1
fullscreen.deactivate,Exit Fullscreen,1,Quitter le mode plein écran,1
editor.feedback,Send Us Feedback,1,[FR] Send Us Feedback,0

Google-translated marked as 0 is prob better than the FR, unless the project has a translations update planned before this goes live. If main is "live" then would suggest changing to unofficial text in French.

@james-rae
Copy link
Member

src/lang/lang.csv line 6 at r1 (raw file):

chapters.menu,Toggle menu,1,Menu à bascule,1
scrollguard.desc,Use ctrl + scroll to zoom the map,1,Utilisez les touches Ctrl et + pour faire un zoom de la carte,1
story.window.title,RAMP Storylines,1,RAMP Storylines,0

now i'm causing problems elsewhere.
not official but I've found two other "official" translations of Storylines, both different lol.
Marketing site calls it Scénarios. An error message in Storylines lang file calls it Synopsis.
And RAMP would becomes PCAR, that one I'm confident on 💪

@james-rae
Copy link
Member

src/lang/lang.csv line 31 at r1 (raw file):

editor.productDetails,Storylines product details,1,Détails du produit de scénarios,1
editor.metadata.instructions,Fill in metadata details about your new Storylines product. Use the "Preview" button to see what your slides will look like.,1,Inscrivez les métadonnées de votre nouveau produit de scénario. Utilisez la fonction « Afficher l’aperçu » pour voir à quoi ressemblent vos diapositives.,1
editor.uuid,UUID,1,UUID,0

line below suggests IDUU is official French.

@james-rae
Copy link
Member

src/lang/lang.csv line 6 at r1 (raw file):

Previously, james-rae (James Rae) wrote…

now i'm causing problems elsewhere.
not official but I've found two other "official" translations of Storylines, both different lol.
Marketing site calls it Scénarios. An error message in Storylines lang file calls it Synopsis.
And RAMP would becomes PCAR, that one I'm confident on 💪

The editor.* keys in the file below all use Scénarios

@james-rae
Copy link
Member

src/lang/lang.csv line 6 at r1 (raw file):

Previously, james-rae (James Rae) wrote…

The editor.* keys in the file below all use Scénarios

and story.error two lines below is using synopsis. So maybe have a vote next project meeting.

Copy link
Member Author

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @james-rae)


src/components/editor/editor.vue line 133 at r1 (raw file):

Previously, james-rae (James Rae) wrote…

You might need to have the subject= content also run through the translation module

Done!


src/lang/lang.csv line 6 at r1 (raw file):

Previously, james-rae (James Rae) wrote…

and story.error two lines below is using synopsis. So maybe have a vote next project meeting.

I'm 99% sure it should be scénarios. I only see synopsis being used in one translation, so I've replaced it.


src/lang/lang.csv line 24 at r1 (raw file):

Previously, james-rae (James Rae) wrote…

Google-translated marked as 0 is prob better than the FR, unless the project has a translations update planned before this goes live. If main is "live" then would suggest changing to unofficial text in French.

Donethanks.


src/lang/lang.csv line 31 at r1 (raw file):

Previously, james-rae (James Rae) wrote…

line below suggests IDUU is official French.

Done.

Copy link
Member

@james-rae james-rae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 7d20a42 into ramp4-pcar4:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants