-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feedback button in footer #297
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-293/#/en/editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @RyanCoulsonCA)
src/components/editor/editor.vue
line 133 at r1 (raw file):
<div class="footer text-right pr-5 editor-button"> <a href="mailto:[email protected]?subject=Storylines Editor Feedback"
You might need to have the subject=
content also run through the translation module
src/lang/lang.csv
line 24 at r1 (raw file):
fullscreen.activate,Enter Fullscreen,1,Afficher le mode plein écran,1 fullscreen.deactivate,Exit Fullscreen,1,Quitter le mode plein écran,1 editor.feedback,Send Us Feedback,1,[FR] Send Us Feedback,0
Google-translated marked as 0 is prob better than the FR, unless the project has a translations update planned before this goes live. If main
is "live" then would suggest changing to unofficial text in French.
now i'm causing problems elsewhere. |
line below suggests |
Previously, james-rae (James Rae) wrote…
The |
Previously, james-rae (James Rae) wrote…
and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @james-rae)
src/components/editor/editor.vue
line 133 at r1 (raw file):
Previously, james-rae (James Rae) wrote…
You might need to have the
subject=
content also run through the translation module
Done!
src/lang/lang.csv
line 6 at r1 (raw file):
Previously, james-rae (James Rae) wrote…
and
story.error
two lines below is usingsynopsis
. So maybe have a vote next project meeting.
I'm 99% sure it should be scénarios. I only see synopsis
being used in one translation, so I've replaced it.
src/lang/lang.csv
line 24 at r1 (raw file):
Previously, james-rae (James Rae) wrote…
Google-translated marked as 0 is prob better than the FR, unless the project has a translations update planned before this goes live. If
main
is "live" then would suggest changing to unofficial text in French.
Donethanks.
src/lang/lang.csv
line 31 at r1 (raw file):
Previously, james-rae (James Rae) wrote…
line below suggests
IDUU
is official French.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)
Related Item(s)
#293
Changes
Testing
Steps:
This change is