Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving for right panels and unsaved alert not appearing #270

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Mar 21, 2024

Related Item(s)

Closes #266

Changes

Fixes issues of not being able to save while making changes on multimedia right panel due to timing of config save + upload to server. Also resolves issue of unsaved changes message not popping up when editing multimedia panel.

Testing

Attempt to make changes and save + reload product to ensure all changes are preserved.


This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-multimedia-saving/#/en/editor

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! One small thing: when editing an image or chart sub-panel of a dynamic panel, the unsaved changes message doesn't appear. It's saving correctly but we probably want the message to show up as well.

Reviewable status: 0 of 4 files reviewed, all discussions resolved

@yileifeng yileifeng force-pushed the fix-multimedia-saving branch from 85035b2 to c3f21ce Compare March 21, 2024 19:04
Copy link
Member Author

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed after build updates

Reviewable status: 0 of 6 files reviewed, all discussions resolved

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@RyanCoulsonCA RyanCoulsonCA merged commit 2caad1e into ramp4-pcar4:main Mar 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes are not saved when working on right panel
2 participants