Update build config, bump up ramp to v4.10.0 #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milespetrov
added
the
PR: Build
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/build-update/#/en/00000000-0000-0000-0000-000000000000 |
james-rae
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @milespetrov)
RyanCoulsonCA
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Great improvements 🏆
Only thing that I've found is that RAMP grid styling seems to have broken somehow:
Reviewed 14 of 15 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
This PR bumps ramp to v4.10.0 and updates some repo and build level configs. Initial download is now 3.4 MB, down from 5 MB due to ramp esDynamic improvements. The initial size of this library can be further reduced once we identify and implement appropriate dynamic imports.
Vite is stuck at v5 due to
vite-plugin-static-copy. Looks like that lib gets updated regularly so we can wait a bit for a patch to v6. Might also make sense to just use thecpcommand.This change is