Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make slideshow map components full height #518

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Dec 16, 2024

Related Item(s)

#508

Changes

  • Map components within a slideshow panel will now take up the full screen height (whilst considering title, caption and the bottom slideshow navigation bar).

Notes

This should fix the problem mentioned in the original issue. It is worth noting, however, that this issue may still appear for similar maps that use a Web Mercator basemap.

From the Slack channel:

Me: Is this expected extent behaviour? It appears that the map gets zoomed out quite a bit when you reduce the map width to ~1175px. It also only appears to happen when using a Web Mercator basemap.

rampextent

Response from @james-rae:

prooobably. You give it an extent. ESRI then has a div of certain size, and that extent, and needs to position the map so the extent fits in the div. You're squeezing in, meaning less room for the width of the extent. Zooming out shrinks it, so it fits. You can attempt to adjust the extent and make it snugger

Testing

Steps:

  1. Open the demo link.
  2. Ensure that any maps that are contained within a slideshow take up the full height of the screen.
  3. Ensure that they also respect mobile resolutions.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-508/#/en/00000000-0000-0000-0000-000000000000

@RyanCoulsonCA RyanCoulsonCA added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Dec 16, 2024
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit f12d40f into ramp4-pcar4:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants