-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for uploaded video asset files in preview #493
Add support for uploaded video asset files in preview #493
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/editor-captions-transcript/#/en/00000000-0000-0000-0000-000000000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should impose a file size limit on this change. Someone could disrespectfully upload a 10 hr rick roll loop, or an 8k video and cause a whole buncha slowness and chaos in the backend.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, this is just extracting the file. Opening an issue in the editor repo to impose a limit.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)
Related Item(s)
ramp4-pcar4/storylines-editor#408, ramp4-pcar4/storylines-editor#267
Changes
configFileStructure
src
directly onto video elementNotes
Published
v3.2.7
to NPM https://www.npmjs.com/package/ramp-storylines_demo-scenarios-pcarTesting
Can test in Storylines Editor when package is updated, for now ensure video panels have no errors in demo.
This change is