Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uploaded video asset files in preview #493

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Oct 25, 2024

Related Item(s)

ramp4-pcar4/storylines-editor#408, ramp4-pcar4/storylines-editor#267

Changes

  • [FEATURE] support for handling captions + transcript files transferred from configFileStructure
  • [FIX] handle locally uploaded video files by appending src directly onto video element

Notes

Published v3.2.7 to NPM https://www.npmjs.com/package/ramp-storylines_demo-scenarios-pcar

Testing

Can test in Storylines Editor when package is updated, for now ensure video panels have no errors in demo.


This change is Reviewable

Copy link

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should impose a file size limit on this change. Someone could disrespectfully upload a 10 hr rick roll loop, or an 8k video and cause a whole buncha slowness and chaos in the backend.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, this is just extracting the file. Opening an issue in the editor repo to impose a limit.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@spencerwahl spencerwahl merged commit f08c6dd into ramp4-pcar4:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants