Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylesheet support #489

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Add stylesheet support #489

merged 2 commits into from
Oct 16, 2024

Conversation

spencerwahl
Copy link
Member

@spencerwahl spencerwahl commented Oct 15, 2024

Related Item(s)

#467

Changes

  • [FEATURE] Adds support for adding css files through the config
  • [FEATURE] Adds property cssClasses to panel configs for classes to add to the panel container
  • [FIX] Add missing customStyles property to panel schema

Testing

Steps:

  1. Open default test page
  2. Scroll to dynamic test panel, you should see an outline on the right side text panel. This is added by the stylesheet specified in the config. The style also targets a class added by the cssClasses property.

This change is Reviewable

Copy link

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

@spencerwahl spencerwahl merged commit 932629e into ramp4-pcar4:main Oct 16, 2024
3 checks passed
@spencerwahl spencerwahl deleted the css-files branch October 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants