add support for templates schema validation after transform #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaEsmukov
approved these changes
Oct 29, 2019
| flow: | ||
| sensor_{{item.name}}: | ||
| - operator_bash | ||
| - operator_simple |
There was a problem hiding this comment.
This example is rather big, and it is hard to tell which part exactly would have failed in master.
Is it this flow which references operators from other do blocks or there's more? If none, would it be possible to simplify the test by stripping everything unrelated to the problem being fixed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trafaret checks schema for operator and sensors in do template. It limits templating.
This PR adds support for invalid schema at templating, but after transform it ensures schema.