Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lep ID and FSR fixes #10

Merged
merged 59 commits into from
Sep 25, 2023
Merged

Lep ID and FSR fixes #10

merged 59 commits into from
Sep 25, 2023

Conversation

YujiLee301
Copy link
Collaborator

@YujiLee301 YujiLee301 commented Aug 31, 2023

  • Lepton ID fix
  • FSR fix
  • Improved the file reading while running locally. Earlier, we need to add root files inside the post-proc.py. Now, we don't need to edit post-proc file anymore, instead just add a text file as one additional arguments while running post-proc.

@ram1123 ram1123 added bug Something isn't working enhancement New feature or request labels Sep 1, 2023
@ram1123 ram1123 added this to the H4l_nanoAOD milestone Sep 1, 2023
@ram1123 ram1123 changed the base branch from HZZ_Analysis to HZZ_Analysis_2l2q September 2, 2023 16:11
@ram1123 ram1123 changed the base branch from HZZ_Analysis_2l2q to HZZ_Analysis September 2, 2023 16:13
@ram1123 ram1123 changed the base branch from HZZ_Analysis to HZZ_Analysis_2l2q_v2_devR September 2, 2023 16:31
@ram1123 ram1123 changed the base branch from HZZ_Analysis_2l2q_v2_devR to HZZ_Analysis September 3, 2023 07:33
@ram1123
Copy link
Owner

ram1123 commented Sep 6, 2023

Hi @YujiLee301 ,

There is still some issue for the data. No event is passing if I give data root file as input.

Will write selected trees to .
Filename root://cms-xrd-global.cern.ch//store/data/Run2018B/SingleMuon/NANOAOD/UL2018_MiniAODv2_NanoAODv9_GT36-v1/2430000/87FA9714-D8D3-1345-BFF5-3B417B1ADC64.root is remote, will do a copy to local path /tmp/rasharma/87FA9714-D8D3-1345-BFF5-3B417B1ADC64-1b548315b3e0db.root
Time used for transferring the file locally: 1.12 s
Pre-select 56973 entries out of 56973 (100.00%)
/afs/cern.ch/work/r/rasharma/nanoAODToolDev_H4l/CMSSW_10_6_30/src/PhysicsTools/NanoAODTools/python/postprocessing/analysis/nanoAOD_skim/Helper.py:10: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  cfg = yaml.load(ymlfile)


Processed    10000/   56973 entries, 17.55% (elapsed time   110.3s, curr speed    0.091 kHz, avg speed    0.091 kHz), accepted        0/   10001 events ( 0.00%)
Processed    20000/   56973 entries, 35.10% (elapsed time   221.6s, curr speed    0.090 kHz, avg speed    0.090 kHz), accepted        0/   20001 events ( 0.00%)
Processed    30000/   56973 entries, 52.66% (elapsed time   334.3s, curr speed    0.089 kHz, avg speed    0.090 kHz), accepted        0/   30001 events ( 0.00%)
Processed    40000/   56973 entries, 70.21% (elapsed time   444.1s, curr speed    0.091 kHz, avg speed    0.090 kHz), accepted        0/   40001 events ( 0.00%)
Processed    50000/   56973 entries, 87.76% (elapsed time   552.9s, curr speed    0.092 kHz, avg speed    0.090 kHz), accepted        0/   50001 events ( 0.00%)
Processed 56973 preselected entries from root://cms-xrd-global.cern.ch//store/data/Run2018B/SingleMuon/NANOAOD/UL2018_MiniAODv2_NanoAODv9_GT36-v1/2430000/87FA9714-D8D3-1345-BFF5-3B417B1ADC64.root (56973 entries). Finally selected 0 entries
Error in <TTree::SetBranchStatus>: No branch name is matching wildcard -> Gen*
Done ./87FA9714-D8D3-1345-BFF5-3B417B1ADC64_Skim.root
PassTrig: 49329 Events
Pass4eCut: 0 Events
Pass4eGhostRemoval: 0 Events
Pass4eLepPtCut: 0 Events
Pass4eQCDSupress: 0 Events
PassmZ1mZ2Cut_4e: 0 Events
Passm4l_105_160_Cut_4e: 0 Events
Pass4muCut: 0 Events
Pass4muGhostRemoval: 0 Events
Pass4muLepPtCut: 0 Events
Pass4muQCDSupress: 0 Events
PassmZ1mZ2Cut_4mu: 0 Events
Passm4l_105_160_Cut_4mu: 0 Events
Pass2e2muCut: 0 Events
Pass2e2muGhostRemoval: 0 Events
Pass2e2muLepPtCut: 0 Events
Pass2e2muQCDSupress: 0 Events
PassmZ1mZ2Cut_2e2mu: 0 Events
Passm4l_105_160_Cut_2e2mu: 0 Events
PassZZSelection: 0 Events

@ram1123
Copy link
Owner

ram1123 commented Sep 6, 2023

@YujiLee301 ,

Also, I updated the post_proc.py. So, you need to pull the changes before updating.

Now it needs also keep_and_drop_data.txt file to run over data. I can't upload there so I am adding it here. Please add it to the commit.

keep_and_drop_data.txt

@ram1123
Copy link
Owner

ram1123 commented Sep 20, 2023

Hi @YujiLee301 ,

If possible, please try to fix this branch today. I want to merge this. So, that we can run over data.

@ram1123
Copy link
Owner

ram1123 commented Sep 20, 2023

Just realised that by mistake you directly pushed into my branch. To avoid this, I protected my branch. From now onwards no one will be able to directly push to branch "HZZ_Analysis" without a PR.

@ram1123
Copy link
Owner

ram1123 commented Sep 20, 2023

For now, just ensure that you run the

  • git pull from main branch which is "HZZ_Analysis" from my repository.
  • Then push to your branch.

Once you will ensure this, I will merge this PR.

YujiLee301 and others added 3 commits September 21, 2023 18:51
   - Added two example.txt file for local running
- Updated condor script
Minor update to read files from local
@ram1123 ram1123 changed the title Add MC info Lep ID and FSR fixes Sep 25, 2023
Copy link
Owner

@ram1123 ram1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things looks fine.

@ram1123 ram1123 merged commit d0a6de6 into ram1123:HZZ_Analysis Sep 25, 2023
@ram1123 ram1123 mentioned this pull request Sep 25, 2023
ram1123 added a commit that referenced this pull request Feb 27, 2024
* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>
ram1123 added a commit that referenced this pull request Oct 4, 2024
* H4L updates

* “Fsr Recovery & Rochester correction”

* Jet Selection Updated

* Mela loaded

* Delete helloworld.h

* Delete NJettiness.h

* Delete NJettiness.cc

* Delete helloworld.cc

* Delete proxy.sh

* Delete condor_setup_lpc.py

* Delete JetSFMaker.py

* Delete HZZAnalysisModule.py

* Delete condor_setup_lxplus.py

* Add files via upload

* Remove redundancy

* Update README.md

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* RoccoR Added

* Path fixed

* Add files via upload

* Add files via upload

* Delete __init__.pyc

* Delete RoccoR.cc

* Delete RoccoR.h

* Update README.md

* Update H4LCppModule.py

* Update keep_and_drop.txt

* Update README.md

Following updates:

- Updated to `CMSSW_10_6_30` from `CMSSW_10_6_20`
- Updated to the latest version of official nanoAOD-tools
- Added back the instruction of batch job.

* Update README.md

* MELA updates

* Delete KalmanMuonCalibrationsProducer/interface directory

* Delete KalmanMuonCalibrationsProducer/plugins directory

* Delete KalmanMuonCalibrationsProducer/python directory

* Delete KalmanMuonCalibrationsProducer/src directory

* Delete BuildFile.xml

* Trigger selection added

* Trigger Updated

* Update keep_and_drop.txt with Mela branches

* Update keep_and_drop.txt

* Update keep_and_drop.txt

* Sync for Lepton

* Add Z selection

* Lepton Module Changed

* hard code removed

* Reading branch modified

* First update for 2l2q

* UPdate the printing style and fixed the flags

* Added additional variables for resolved category

* updated condor script

* Added total number of events to print and in post-proc.py switched total entries to run to all

* Fixed the bug for FatJet selection; Updated the log summary

* Removed unnecessary lines

* Updated trigger list similar to HIG-23-001

* Update condor_setup_lxplus.py

To avoid confusion, I updated the name of the variables.

Also, I added all the variables we might update for each run in argparser.

* Updated Trigger list for 2l2q channel; Added mll cut of 40-180 GeV, and added option for output log file path in condor script

* Added argparser to GetLogSummary.py script; Added 2017 trigger list to Helper.py script; Added UL2017 root file path to post_proc.py

* - Updated 2018 trigger list for 202q

- Added option in post-proc such that it won't break the condor job

* made compatible with python2

* making compatible with python2

* added new root file

* Updated utils files; made compitable with python2

* added energy, pt, eta and phi for 2j system

* updated 2j part to ZZ system

* updated 2j part to ZZ system

* updated file

* updated file

* changes for 2l2nu branch

* update to the 2l2nu part

* Revert "Adding HZZ->2l2nu Category" (#15)

* - Removed the submodule utils

* - Minor update in condor submission script.
- Added summary of additional script information in the README file

* Added golden json information to post-proc

* - Few files changed "nanoAOD_vvVBS" -> "nanoAOD_skim"
- Added golden josn file (last commit there was a bug)
- Added JME corrector
- Added PU SF module
- Added bTag SF module (For now its not working)

* added data root file

* update

* Hzz analysis 2l2q v2 dev r (#5)

* Add golden json & fix submodule utils (#16)

* - Removed the submodule utils

* - Minor update in condor submission script.
- Added summary of additional script information in the README file

* Added golden json information to post-proc

* - replaced string "nanoAOD_vvVBS"  to "nanoAOD_skim" in few files
- Fix the json bug (For MC we don't need to provide)
- Added modules createJMECorrector, btagSFProducer, etc

* - Still issue with the btagSF
- Updated the method for modules to run
- Added PUWeightProducer

* Added a text file having list of MC samples

* Added additional cuts for 2l2q channel

* - Improved post-proc for the condor jobs submission

* Fix a bug in root file name

* input file updated to run over data and mc

* updates for running over data sample

* updates

* update for nElectron/nMuon issue

* update

* updates

* updates

* Debuging the cut-flow between h4l and h2l2q.. bug is still there

* Update H4LCppModule.py

Fixed the bug of bool branch passZZ*

* Hzz analysis 2l2v dev (#6)

* corrected TLorentz vector for MET part

* updates

* updates

* updates

* updated with MET part

* updated with MET part

* updates

* updates

* Temporary

* updates

* updates

* update for merging 2l2q and 2l2nu

* Fixed lepton selection

* updates

* BUGFIX: Leading two leptons kinematics were identical for all events (#7)

* Fixed the bug of bool branch passZZ*

* RoccoR with official nano-tools (#27)

* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: yuji <[email protected]>

* mergeOutput.py

* Some minor changes

* Added modules/functions for MET filters and GEN variables (#20)

* - Improved post-proc for the condor jobs submission

* Fix a bug in root file name

* Added the GEN producer and the MET filter

* - Added total entries
- Updated event summary print statement

* Committed changes without testing

* Updated keep_and_drop files

* Added METfilter in cut-flow

* Updated README

* Updating formating mainly to improve readebility

* Improved working of "--NOsyst" option

* - BUGFIX: Each leptons had same pT value. This is because we forgot the clear the vector.
- Added DEBUG option
- Updated condor job such that it can run over sl7 machine

* BugFix: We need to initialize TLorentzVector everytime by 0

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>

* Update for 2l2nu and Bug fix for 2l2q channel (#9)

* RoccoR with official nano-tools (#27)

* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: yuji <[email protected]>

* # For 2l2nu channel

- Added b-tagged jet info
- Added VBF jets and VBF di-jet kinematics. Along with the VBF jet index

# For 2l2q channel

BUGFIX-1: Updated "jetidx.size()+1" with "jetidx.size()" to select di-jet

BUBFIX-2: Jet index was wrong while accessing jets info when selecting based on mass

BUGFIX-3: Also, fixed jet index that was saved in output branch

* Added deltaPhi var for 2l2nu channel

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>

* RoccoR with official nano-tools (#27) (#10)

* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>

* Some fixes (#11)

* Update condor job info and keep_and_drop file

* Fix: Size of output root file

Details here: #38

* - Updated condor job script
- Updated condor job resubmit script
- Updated the keep and drop file- reduced the list
- Updated the merge nanoAOD root file script
- Updated README file

* - Updated condor setup script
- Updated condor resubmit script
- Added nanoAOD root file hadd-ed script

* Updated keep_and_drop*.txt

* - Removed the hardcoded output root file name in the post-proc and in the condor job script

* Added few scripts; later remove once that are not necessary or obselete

* Running version after update 2l2nu function

* Added some new variables to the output and naming convention

* Some updates to workflow of 2l2nu and 2l2q

* Removed the hardcoded cut-flow json file name and added option "--Nosyst" in condor script so that one can submit jobs without systematics

* - Updated 2018 YAML file to incorporate the separate trigger list for the different final states
- Accordingly update the code

* updates

* selection of z1 candidate for emu control region

* emu controlregion - lepton pt and eta update

* updates for emu control region

* updates

* update to find delta boost between two Z bosons

* Pz of neutrino

* update

* change of initial values of njets

* Merge branch and some minor changes (#12)

* Update condor job info and keep_and_drop file

* Fix: Size of output root file

Details here: #38

* - Updated condor job script
- Updated condor job resubmit script
- Updated the keep and drop file- reduced the list
- Updated the merge nanoAOD root file script
- Updated README file

* - Updated condor setup script
- Updated condor resubmit script
- Added nanoAOD root file hadd-ed script

* Updated keep_and_drop*.txt

* - Removed the hardcoded output root file name in the post-proc and in the condor job script

* Added few scripts; later remove once that are not necessary or obselete

* Running version after update 2l2nu function

* Added some new variables to the output and naming convention

* Some updates to workflow of 2l2nu and 2l2q

* Removed the hardcoded cut-flow json file name and added option "--Nosyst" in condor script so that one can submit jobs without systematics

* - Updated 2018 YAML file to incorporate the separate trigger list for the different final states
- Accordingly update the code

* - BugFix: Mass windown of leptonic Z boson was missing the `fabs` function, which caused the window to be incorrectly defined
- BugFix: nJets branches should be initialize with ZERO, but it was initialize with -999
- Removed b-tag cut from 2l2nu selection
- Moved the hardcoded b-tag cut to the configuration file
- Added missing background samples

* - BugFix: Condor job not using custom name for the cut-flow file
- BugFix: If two sample names are same then it checks for word `ext` in the name to differentiate them

* Added script to remove duplicates from root file

* Updated condor for the output dir naming convention

* To avoid updating two keep and drop file I made two list for general variable and MC variables and keep them in .py file. Now, we need to write any variable only once in proper list GEN only or Data_MC.

* update lepton id

* update lepton id

* update lepton id

* update lepton id

* updates for lepton id

* update on object selection

* update for jet_puid for pt < 50

* update for jet_puid for pt < 50

* update for jet_puid for pt < 50

* update for object selection

* update for gen part

* update for gen part

* update for gen part

* update to the gen part

* update to pz of neutrino

* list of signal dataset for different mass point

* Bug fix and condor improvement (#13)

* Removed transfer file from condor as now we don't have any files to transfer

* Now condor job will take arguments from txt file instead of many jdl files #51

* Update .write method to file instead of multi-string now just using one string using """

* As yaml-cpp is not available on el7 container so now cloe the yaml-cpp package and build it to remove the official dependencies. This solves Issue #54

* - Fix the ele eta cut for barrel and endcap transition
- Added the print statement under debug condition
- Added all high mass 2l2nu signal sample

* Changing the setup to work with EL9 #56

* Added variables to yml file for studying Di and single lepton triggers. (#57)

* Added variables to yml file for studying Di and single lepton triggers.

* Added leptons high pT triggers

---------

Co-authored-by: skeshri <[email protected]>

* Update condor script

* Fixed the library issue and nanohadd script fix for python2 to 3 shift

* Update condor job script

* Added output Dir option when running locally

* BugFix: Condor resubmit script is adapted as per the changes made for improving condor script #51 #56

---------

Co-authored-by: skeshri <[email protected]>
Co-authored-by: skeshri <[email protected]>

* Updated README (#14)

* - Bugfix for GEN variables module. It was also triggering for the data but it should not. (#15)

- Added VBF MC sample in the sample list
- Updated the README

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: Ramkrishna Sharma <[email protected]>
Co-authored-by: Ram Krishna Sharma <[email protected]>
Co-authored-by: yuji <[email protected]>
Co-authored-by: skeshri <[email protected]>
Co-authored-by: skeshri <[email protected]>
ram1123 added a commit that referenced this pull request Dec 2, 2024
* Updates for 2l2q channel (#4)

* H4L updates

* “Fsr Recovery & Rochester correction”

* Jet Selection Updated

* Mela loaded

* Delete helloworld.h

* Delete NJettiness.h

* Delete NJettiness.cc

* Delete helloworld.cc

* Delete proxy.sh

* Delete condor_setup_lpc.py

* Delete JetSFMaker.py

* Delete HZZAnalysisModule.py

* Delete condor_setup_lxplus.py

* Add files via upload

* Remove redundancy

* Update README.md

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* RoccoR Added

* Path fixed

* Add files via upload

* Add files via upload

* Delete __init__.pyc

* Delete RoccoR.cc

* Delete RoccoR.h

* Update README.md

* Update H4LCppModule.py

* Update keep_and_drop.txt

* Update README.md

Following updates:

- Updated to `CMSSW_10_6_30` from `CMSSW_10_6_20`
- Updated to the latest version of official nanoAOD-tools
- Added back the instruction of batch job.

* Update README.md

* MELA updates

* Delete KalmanMuonCalibrationsProducer/interface directory

* Delete KalmanMuonCalibrationsProducer/plugins directory

* Delete KalmanMuonCalibrationsProducer/python directory

* Delete KalmanMuonCalibrationsProducer/src directory

* Delete BuildFile.xml

* Trigger selection added

* Trigger Updated

* Update keep_and_drop.txt with Mela branches

* Update keep_and_drop.txt

* Update keep_and_drop.txt

* Sync for Lepton

* Add Z selection

* Lepton Module Changed

* hard code removed

* Reading branch modified

* First update for 2l2q

* UPdate the printing style and fixed the flags

* Added additional variables for resolved category

* updated condor script

* Added total number of events to print and in post-proc.py switched total entries to run to all

* Fixed the bug for FatJet selection; Updated the log summary

* Removed unnecessary lines

* Updated trigger list similar to HIG-23-001

* Update condor_setup_lxplus.py

To avoid confusion, I updated the name of the variables.

Also, I added all the variables we might update for each run in argparser.

* Updated Trigger list for 2l2q channel; Added mll cut of 40-180 GeV, and added option for output log file path in condor script

* Added argparser to GetLogSummary.py script; Added 2017 trigger list to Helper.py script; Added UL2017 root file path to post_proc.py

* - Updated 2018 trigger list for 202q

- Added option in post-proc such that it won't break the condor job

* made compatible with python2

* making compatible with python2

* added new root file

* Updated utils files; made compitable with python2

* added energy, pt, eta and phi for 2j system

* updated 2j part to ZZ system

* updated 2j part to ZZ system

* updated file

* updated file

* changes for 2l2nu branch

* update to the 2l2nu part

* Revert "Adding HZZ->2l2nu Category" (#15)

* - Removed the submodule utils

* - Minor update in condor submission script.
- Added summary of additional script information in the README file

* Added golden json information to post-proc

* - Few files changed "nanoAOD_vvVBS" -> "nanoAOD_skim"
- Added golden josn file (last commit there was a bug)
- Added JME corrector
- Added PU SF module
- Added bTag SF module (For now its not working)

* added data root file

* update

* Hzz analysis 2l2q v2 dev r (#5)

* Add golden json & fix submodule utils (#16)

* - Removed the submodule utils

* - Minor update in condor submission script.
- Added summary of additional script information in the README file

* Added golden json information to post-proc

* - replaced string "nanoAOD_vvVBS"  to "nanoAOD_skim" in few files
- Fix the json bug (For MC we don't need to provide)
- Added modules createJMECorrector, btagSFProducer, etc

* - Still issue with the btagSF
- Updated the method for modules to run
- Added PUWeightProducer

* Added a text file having list of MC samples

* Added additional cuts for 2l2q channel

* - Improved post-proc for the condor jobs submission

* Fix a bug in root file name

* input file updated to run over data and mc

* updates for running over data sample

* updates

* update for nElectron/nMuon issue

* update

* updates

* updates

* Debuging the cut-flow between h4l and h2l2q.. bug is still there

* Update H4LCppModule.py

Fixed the bug of bool branch passZZ*

* Hzz analysis 2l2v dev (#6)

* corrected TLorentz vector for MET part

* updates

* updates

* updates

* updated with MET part

* updated with MET part

* updates

* updates

* Temporary

* updates

* updates

* update for merging 2l2q and 2l2nu

* Fixed lepton selection

* updates

* BUGFIX: Leading two leptons kinematics were identical for all events (#7)

* Fixed the bug of bool branch passZZ*

* RoccoR with official nano-tools (#27)

* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: yuji <[email protected]>

* mergeOutput.py

* Some minor changes

* Added modules/functions for MET filters and GEN variables (#20)

* - Improved post-proc for the condor jobs submission

* Fix a bug in root file name

* Added the GEN producer and the MET filter

* - Added total entries
- Updated event summary print statement

* Committed changes without testing

* Updated keep_and_drop files

* Added METfilter in cut-flow

* Updated README

* Updating formating mainly to improve readebility

* Improved working of "--NOsyst" option

* - BUGFIX: Each leptons had same pT value. This is because we forgot the clear the vector.
- Added DEBUG option
- Updated condor job such that it can run over sl7 machine

* BugFix: We need to initialize TLorentzVector everytime by 0

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>

* Update for 2l2nu and Bug fix for 2l2q channel (#9)

* RoccoR with official nano-tools (#27)

* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: yuji <[email protected]>

* # For 2l2nu channel

- Added b-tagged jet info
- Added VBF jets and VBF di-jet kinematics. Along with the VBF jet index

# For 2l2q channel

BUGFIX-1: Updated "jetidx.size()+1" with "jetidx.size()" to select di-jet

BUBFIX-2: Jet index was wrong while accessing jets info when selecting based on mass

BUGFIX-3: Also, fixed jet index that was saved in output branch

* Added deltaPhi var for 2l2nu channel

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>

* RoccoR with official nano-tools (#27) (#10)

* RoccoRUpdate

* Delete KalmanMuonCalibrationsProducer/data/roccor.Run2.v5 directory

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>

* Some fixes (#11)

* Update condor job info and keep_and_drop file

* Fix: Size of output root file

Details here: #38

* - Updated condor job script
- Updated condor job resubmit script
- Updated the keep and drop file- reduced the list
- Updated the merge nanoAOD root file script
- Updated README file

* - Updated condor setup script
- Updated condor resubmit script
- Added nanoAOD root file hadd-ed script

* Updated keep_and_drop*.txt

* - Removed the hardcoded output root file name in the post-proc and in the condor job script

* Added few scripts; later remove once that are not necessary or obselete

* Running version after update 2l2nu function

* Added some new variables to the output and naming convention

* Some updates to workflow of 2l2nu and 2l2q

* Removed the hardcoded cut-flow json file name and added option "--Nosyst" in condor script so that one can submit jobs without systematics

* - Updated 2018 YAML file to incorporate the separate trigger list for the different final states
- Accordingly update the code

* updates

* selection of z1 candidate for emu control region

* emu controlregion - lepton pt and eta update

* updates for emu control region

* updates

* update to find delta boost between two Z bosons

* Pz of neutrino

* update

* change of initial values of njets

* Merge branch and some minor changes (#12)

* Update condor job info and keep_and_drop file

* Fix: Size of output root file

Details here: #38

* - Updated condor job script
- Updated condor job resubmit script
- Updated the keep and drop file- reduced the list
- Updated the merge nanoAOD root file script
- Updated README file

* - Updated condor setup script
- Updated condor resubmit script
- Added nanoAOD root file hadd-ed script

* Updated keep_and_drop*.txt

* - Removed the hardcoded output root file name in the post-proc and in the condor job script

* Added few scripts; later remove once that are not necessary or obselete

* Running version after update 2l2nu function

* Added some new variables to the output and naming convention

* Some updates to workflow of 2l2nu and 2l2q

* Removed the hardcoded cut-flow json file name and added option "--Nosyst" in condor script so that one can submit jobs without systematics

* - Updated 2018 YAML file to incorporate the separate trigger list for the different final states
- Accordingly update the code

* - BugFix: Mass windown of leptonic Z boson was missing the `fabs` function, which caused the window to be incorrectly defined
- BugFix: nJets branches should be initialize with ZERO, but it was initialize with -999
- Removed b-tag cut from 2l2nu selection
- Moved the hardcoded b-tag cut to the configuration file
- Added missing background samples

* - BugFix: Condor job not using custom name for the cut-flow file
- BugFix: If two sample names are same then it checks for word `ext` in the name to differentiate them

* Added script to remove duplicates from root file

* Updated condor for the output dir naming convention

* To avoid updating two keep and drop file I made two list for general variable and MC variables and keep them in .py file. Now, we need to write any variable only once in proper list GEN only or Data_MC.

* update lepton id

* update lepton id

* update lepton id

* update lepton id

* updates for lepton id

* update on object selection

* update for jet_puid for pt < 50

* update for jet_puid for pt < 50

* update for jet_puid for pt < 50

* update for object selection

* update for gen part

* update for gen part

* update for gen part

* update to the gen part

* update to pz of neutrino

* list of signal dataset for different mass point

* Bug fix and condor improvement (#13)

* Removed transfer file from condor as now we don't have any files to transfer

* Now condor job will take arguments from txt file instead of many jdl files #51

* Update .write method to file instead of multi-string now just using one string using """

* As yaml-cpp is not available on el7 container so now cloe the yaml-cpp package and build it to remove the official dependencies. This solves Issue #54

* - Fix the ele eta cut for barrel and endcap transition
- Added the print statement under debug condition
- Added all high mass 2l2nu signal sample

* Changing the setup to work with EL9 #56

* Added variables to yml file for studying Di and single lepton triggers. (#57)

* Added variables to yml file for studying Di and single lepton triggers.

* Added leptons high pT triggers

---------

Co-authored-by: skeshri <[email protected]>

* Update condor script

* Fixed the library issue and nanohadd script fix for python2 to 3 shift

* Update condor job script

* Added output Dir option when running locally

* BugFix: Condor resubmit script is adapted as per the changes made for improving condor script #51 #56

---------

Co-authored-by: skeshri <[email protected]>
Co-authored-by: skeshri <[email protected]>

* Updated README (#14)

* - Bugfix for GEN variables module. It was also triggering for the data but it should not. (#15)

- Added VBF MC sample in the sample list
- Updated the README

---------

Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: Ramkrishna Sharma <[email protected]>
Co-authored-by: Ram Krishna Sharma <[email protected]>
Co-authored-by: yuji <[email protected]>
Co-authored-by: skeshri <[email protected]>
Co-authored-by: skeshri <[email protected]>

* updates for emu control region (#62)

* updates for emu control region

* updates for emu control region

* updates for emu control region

* updates to emu control region

* modified print statement

* Addition of cutflow histogram (#63)

* updates for emu control region

* updates for emu control region

* updates for emu control region

* updates to emu control region

* modified print statement

* addition of cutflow histogram

* add cutflow table

* add cutflow table

* add cutflow table

* update for cutflow table

* cut flow table

* cut-flow bug fix (#16)

* cut-flow bug fix

* - Updated naming convention for systematics
- Added script to set the environment named `set_env.sh`
- Updated README
- Added script to get the text file for sync

* Added the arguments to choose which channel to run

* Bug fix

---------

Co-authored-by: Ram krishna Sharma <[email protected]>

* Code restructured & Option to run all three channels (#66)

* First running version of all channels: But it does not contain the latest run3 changes

* Removed unwanted files and updated README

* Restructured the code

* Update README.md

Updated path for commit to master branch

* Update setup.sh

Updated branch for accepting PR to master

* Update README.md

Updated branch name for accepting PR to master

---------

Co-authored-by: Anusreevijay769 <[email protected]>
Co-authored-by: YujiLee301 <[email protected]>
Co-authored-by: yuji <[email protected]>
Co-authored-by: skeshri <[email protected]>
Co-authored-by: skeshri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nanoAOD validation using miniAOD Ghost removal Skip running on gen information for data
2 participants