Add support for Functions #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in https://platform.openai.com/docs/guides/gpt/function-calling some models have been fine tuned to call functions based on their JSON representations.
To indicate an empty parameter, the properties must be emitted as `{}`.
But we also need a nil properties field to not be emitted at all. This
is not handled by `omitempty` because it treats nil and empty as the
same.
rhettg
added a commit
to rhettg/openai-go
that referenced
this pull request
Aug 21, 2023
These fields are required. Content is allowed to be empty. This behavior can be observed by trying to include a FunctionCall Message (see also rakyll#25) which has no Content. The API will reject it. The OpenAPI specification for this type (https://github.com/openai/openai-openapi/blob/e6277eabbbb5df1e90620e3657bb02da28dce460/openapi.yaml#L2195-L2197) shows the following: ```yaml ChatCompletionRequestMessage: properties: ... content: type: string nullable: true description: The contents of the message. `content` is required for all messages, and may be null for assistant messages with function calls. ... required: - role - content ``` I've confirmed experimentally it accepts empty strings as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://platform.openai.com/docs/guides/gpt/function-calling some models have been fine tuned to call functions based on their JSON representations.
This hasn't had a lot of use yet, I'm still playing with it. But it seems mostly right at least.
The only tricky part is serializing the JSON schema. I can't say I'm very happy with how this looks but it does work. Open to suggestions.