Add create image edit #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ysinjab
commented
Mar 26, 2023
ysinjab
commented
- Refactor Upload function to support uplading multiple files
- Add support for create image edit. Check image/edit.go
- Refactor examples/images to include two examples (edit & create)
- Rename json tag for CreatedAt to Created
rakyll
reviewed
Apr 5, 2023
examples/image/create/main.go
Outdated
| N: 3, | ||
| Prompt: "a cute baby", | ||
| Size: "1024x1024", | ||
| ResponseFormat: "b64_json", |
There was a problem hiding this comment.
Could you please explain what do you mean by "break it"? do you mean into separate task or PR? or into set of values like enum?
There was a problem hiding this comment.
I was wondering if we can keep this as Format not to break the existing package.
There was a problem hiding this comment.
Oh yes I got it now! I revert the field ResponseFormat to Format. I also reverted Created to CreatedAt.
examples/image/edit/main.go
Outdated
| log.Fatalf("ReadAll error: %v", err) | ||
| } | ||
| _ = data // use data | ||
|
|
image/create.go
Outdated
| Prompt string `json:"prompt,omitempty"` | ||
| N int `json:"n,omitempty"` | ||
| Size string `json:"size,omitempty"` | ||
| ResponseFormat string `json:"response_format,omitempty"` |
image/edit.go
Outdated
| Size string | ||
| ResponseFormat string | ||
| User string | ||
| N *int |
There was a problem hiding this comment.
Let's use N int here, you can omit it if it's 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.