Skip to content

fix some linting errors (#83) #1

fix some linting errors (#83)

fix some linting errors (#83) #1

Triggered via push January 3, 2024 16:05
Status Failure
Total duration 1m 46s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
lint: informer_jobs.go#L39
Error return value is not checked (errcheck)
lint: watcher_events.go#L254
Error return value is not checked (errcheck)
lint: watcher_pods.go#L196
Error return value is not checked (errcheck)
lint: crons_monitor_data_test.go#L98
string `TestAddCronsMonitorDataCronJob` has 3 occurrences, make it a constant (goconst)
lint: sentry_dsn_data_test.go#L35
string `https://c6f9a148ee0775891414b50b9af35959@o4506191942320128.ingest.sentry.io/1234567890` has 4 occurrences, make it a constant (goconst)
lint: crons_monitor_data_test.go#L12
string `080181f33ca343f89b0bf55d50abfeee` has 3 occurrences, make it a constant (goconst)
lint: crons_monitor_data_test.go#L39
string `* * * * *` has 5 occurrences, make it a constant (goconst)
lint: crons.go#L56
ifElseChain: rewrite if-else to switch statement (gocritic)
lint: crons.go#L123
ifElseChain: rewrite if-else to switch statement (gocritic)
lint: informer_cronjobs.go#L14
createCronjobInformer - result 1 (error) is always nil (unparam)
lint: sentry.go#L12
unused-parameter: parameter 'hint' seems to be unused, consider removing or renaming it as _ (revive)
lint: context.go#L28
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
lint: mocks_test.go#L15
unused-parameter: parameter 'options' seems to be unused, consider removing or renaming it as _ (revive)
lint: mocks_test.go#L21
unused-parameter: parameter 'timeout' seems to be unused, consider removing or renaming it as _ (revive)
lint: crons_monitor_data.go#L16
var-naming: func parameter checkinId should be checkinID (revive)
lint: enhancers_common_test.go#L7
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
lint: crons.go#L23
unused-parameter: parameter 'eventHandlerType' seems to be unused, consider removing or renaming it as _ (revive)
lint: crons.go#L122
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
lint: enhancers.go#L196
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: enhancers.go#L225
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)