Support for go 1.6 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <[email protected]>
In Go 1.6, arguments passed to C cannot be a Go pointer to memory containing Go pointers. Fix by converting argument to uintptr instead of unsafe.Pointer
Calling sum8 in TestStackArguments fails apparently due to compiler optimizations which leads the function return value to be 0 instead of the expected 36. Fix by disabling compiler optimizations in CFLAGS
Open
|
The issue with TestStackArguments is caused by a bug which is better solved by a proper bug fix in #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two commits. One to fix the dreaded
panic: runtime error: cgo argument has Go pointer to Go pointer, and one to fix the testTestStackArgumentswhich was fixed by disabling compiler optimizations.The PR also includes the commit from tiborvass' PR