Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Firefox extension keyboard shortcuts #1

Closed
wants to merge 1 commit into from

Conversation

jdrch
Copy link

@jdrch jdrch commented Jul 13, 2024

Restores Firefox extension keyboard shortcuts, which currently don't work.

I took most of the code from the legacy Manifest V2 extension manifest.json, except for changing "_execute_browser_action" to "_execute_action" for Manifest V3 compatibility.

Restores Firefox extension keyboard shortcuts, which [currently don't work](raindropio/app#121). 

I took most of the code was taken from the[ legacy Manifest V2 extension `manifest.json`](https://github.com/raindropio/extensions/blob/master/src/config/manifest.json), except for changing `"_execute_browser_action"` to `"_execute_action"` for [Manifest V3 compatibility](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands#syntax)
@exentrich
Copy link
Member

It's not a real Raindrop.io app, just a test extension to debug highlighting.

@exentrich exentrich closed this Jul 22, 2024
@jdrch
Copy link
Author

jdrch commented Jul 22, 2024

It's not a real Raindrop.io app, just a test extension to debug highlighting.

OK thanks for the info. What repo is the Firefox extension in, then?

@exentrich
Copy link
Member

@jdrch
Copy link
Author

jdrch commented Jul 22, 2024

https://github.com/raindropio/app

Thanks, I saw that, but I couldn't find any manifest.json file. Where is the extension manifest defined?

@exentrich
Copy link
Member

https://github.com/raindropio/app/blob/master/src/target/extension/manifest/index.js
The issue with non working shortcuts have been resolved, new version is on the way to Firefox store.
Main problem is that we used forbidden hotkey combinations.

@jdrch
Copy link
Author

jdrch commented Jul 22, 2024

https://github.com/raindropio/app/blob/master/src/target/extension/manifest/index.js The issue with non working shortcuts have been resolved, new version is on the way to Firefox store. Main problem is that we used forbidden hotkey combinations.

Ah, I see. Thanks for the fix!

Looks like the keyboard shortcuts are defined here. Is that correct?

@exentrich
Copy link
Member

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants