Patch for XSS fix #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brakeman version 1.2.1 (https://github.com/presidentbeef/brakeman) reports the vulnerability in translate helper for Rails 2.3.14 using the rails_xss plugin. Would this patch address the problem? What is the reason that it is not being applied? Has the vulnerability been addressed in any other way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to incorporate a fix to escape interpolations in the translate helper method introduced in Rails 3.1.2. This patch should be compatible with Rails 2.3.8 ... 2.3.14.
I'd have preferred to method chain translate but there didn't seem to be a clean, backwards compatible way of doing so while still supporting multiple keys.
John