Add categories to blog posts #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @iamchrissmith, I'm sorry I haven't been able to review your PR until now, it's just been very busy! I definitely have this on my list for this week, I hope to be able to take a look at it tomorrow or on Friday. Thanks so much for your patience! |
alicetragedy
approved these changes
Oct 23, 2017
There was a problem hiding this comment.
hey @iamchrissmith, thank you so much for your patience and for your contribution! ✨
This looks great and I believe we can already merge it. Yay! Congrats! 🎉
A couple of small improvements I think we could make for the future (in case you're interested in contributing sometime again):
- also show the categories on the main blog index
- remove the space before the comma for when there's more than 2 categories (this is sort of bugging me, but I'm not sure how to fix it yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #211
This adds the categories of a blog post to the meta display just below the Posted on and Author information.
The categories link to the categoryview anchor tag unless it is the main
blogcategory. This had to stay in for now since it would mess up the insertion of commas and 'and'. Since it did not have an anchor tag on the categoryview page, I liked it back to the main blog page.